Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2153)

Unified Diff: Source/web/WebNodeCollection.cpp

Issue 137433008: Have HTMLCollection::item() return an Element as per specification (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebHelperPluginImpl.cpp ('k') | Source/web/WebPageSerializer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebNodeCollection.cpp
diff --git a/Source/web/WebNodeCollection.cpp b/Source/web/WebNodeCollection.cpp
index 1715730473d822a39be3283c2f41dc4ee3b24766..2d10044b63c946356cfe1dddf738cd35f490434e 100644
--- a/Source/web/WebNodeCollection.cpp
+++ b/Source/web/WebNodeCollection.cpp
@@ -31,12 +31,11 @@
#include "config.h"
#include "WebNodeCollection.h"
+#include "WebElement.h"
#include "core/dom/Node.h"
#include "core/html/HTMLCollection.h"
#include "wtf/PassRefPtr.h"
-#include "WebNode.h"
-
using namespace WebCore;
namespace blink {
@@ -72,15 +71,15 @@ unsigned WebNodeCollection::length() const
return m_private->length();
}
-WebNode WebNodeCollection::nextItem() const
+WebElement WebNodeCollection::nextItem() const
{
- Node* node = m_private->item(m_current);
- if (node)
+ Element* element = m_private->item(m_current);
+ if (element)
m_current++;
- return WebNode(node);
+ return WebElement(element);
}
-WebNode WebNodeCollection::firstItem() const
+WebElement WebNodeCollection::firstItem() const
{
m_current = 0;
return nextItem();
« no previous file with comments | « Source/web/WebHelperPluginImpl.cpp ('k') | Source/web/WebPageSerializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698