Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Side by Side Diff: Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp

Issue 137433008: Have HTMLCollection::item() return an Element as per specification (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/v8/V8WindowShell.cpp ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 if (index.IsEmpty()) { 64 if (index.IsEmpty()) {
65 V8TRYCATCH_FOR_V8STRINGRESOURCE_RETURN(V8StringResource<>, name, argumen t, v8::Undefined(info.GetIsolate())); 65 V8TRYCATCH_FOR_V8STRINGRESOURCE_RETURN(V8StringResource<>, name, argumen t, v8::Undefined(info.GetIsolate()));
66 v8::Handle<v8::Value> result = getNamedItems(collection, name, info); 66 v8::Handle<v8::Value> result = getNamedItems(collection, name, info);
67 67
68 if (result.IsEmpty()) 68 if (result.IsEmpty())
69 return v8::Undefined(info.GetIsolate()); 69 return v8::Undefined(info.GetIsolate());
70 70
71 return result; 71 return result;
72 } 72 }
73 73
74 RefPtr<Node> result = collection->item(index->Uint32Value()); 74 RefPtr<Element> result = collection->item(index->Uint32Value());
75 return toV8(result.release(), info.Holder(), info.GetIsolate()); 75 return toV8(result.release(), info.Holder(), info.GetIsolate());
76 } 76 }
77 77
78 void V8HTMLAllCollection::itemMethodCustom(const v8::FunctionCallbackInfo<v8::Va lue>& info) 78 void V8HTMLAllCollection::itemMethodCustom(const v8::FunctionCallbackInfo<v8::Va lue>& info)
79 { 79 {
80 HTMLAllCollection* imp = V8HTMLAllCollection::toNative(info.Holder()); 80 HTMLAllCollection* imp = V8HTMLAllCollection::toNative(info.Holder());
81 v8SetReturnValue(info, getItem(imp, info[0], info)); 81 v8SetReturnValue(info, getItem(imp, info[0], info));
82 } 82 }
83 83
84 void V8HTMLAllCollection::namedItemMethodCustom(const v8::FunctionCallbackInfo<v 8::Value>& info) 84 void V8HTMLAllCollection::namedItemMethodCustom(const v8::FunctionCallbackInfo<v 8::Value>& info)
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 if (index.IsEmpty()) 118 if (index.IsEmpty())
119 return; 119 return;
120 120
121 if (Node* node = imp->namedItemWithIndex(name, index->Uint32Value())) { 121 if (Node* node = imp->namedItemWithIndex(name, index->Uint32Value())) {
122 v8SetReturnValueFast(info, node, imp); 122 v8SetReturnValueFast(info, node, imp);
123 return; 123 return;
124 } 124 }
125 } 125 }
126 126
127 } // namespace WebCore 127 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/V8WindowShell.cpp ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698