Source/core/html/HTMLAllCollection.cpp - Issue 137433008: Have HTMLCollection::item() return an Element as per specification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLAllCollection.cpp

Issue 137433008: Have HTMLCollection::item() return an Element as per specification (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLAllCollection.cpp

diff --git a/Source/core/html/HTMLAllCollection.cpp b/Source/core/html/HTMLAllCollection.cpp

index c4f5b7ee9ad342963d32206c0cfde3ef5ea13f0c..d00850691477635e7413c1b7f412072743b10db4 100644

--- a/Source/core/html/HTMLAllCollection.cpp

+++ b/Source/core/html/HTMLAllCollection.cpp

@@ -46,7 +46,7 @@ HTMLAllCollection::~HTMLAllCollection()

{

}

-Node* HTMLAllCollection::namedItemWithIndex(const AtomicString& name, unsigned index) const

+Element* HTMLAllCollection::namedItemWithIndex(const AtomicString& name, unsigned index) const

{

updateNameCache();

« no previous file with comments | « Source/core/html/HTMLAllCollection.h ('k') | Source/core/html/HTMLAllCollection.idl » ('j') | no next file with comments »