Source/core/html/HTMLAllCollection.h - Issue 137433008: Have HTMLCollection::item() return an Element as per specification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLAllCollection.h

Issue 137433008: Have HTMLCollection::item() return an Element as per specification (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLAllCollection.h

diff --git a/Source/core/html/HTMLAllCollection.h b/Source/core/html/HTMLAllCollection.h

index 323773aa6b74c33eeb6ffa88b4f531459136fdb1..d406efaa88fd2ff1c4aa4865d3da214f668fdd09 100644

--- a/Source/core/html/HTMLAllCollection.h

+++ b/Source/core/html/HTMLAllCollection.h

@@ -35,7 +35,7 @@ public:

static PassRefPtr<HTMLAllCollection> create(ContainerNode*, CollectionType);

virtual ~HTMLAllCollection();

- Node* namedItemWithIndex(const AtomicString& name, unsigned index) const;

+ Element* namedItemWithIndex(const AtomicString& name, unsigned index) const;

void anonymousNamedGetter(const AtomicString& name, bool&, RefPtr<NodeList>&, bool&, RefPtr<Element>&);

PassRefPtr<HTMLCollection> tags(const AtomicString&);

« no previous file with comments | « Source/core/html/CollectionIndexCache.h ('k') | Source/core/html/HTMLAllCollection.cpp » ('j') | no next file with comments »