Source/core/html/HTMLSelectElement.h - Issue 137433008: Have HTMLCollection::item() return an Element as per specification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSelectElement.h

Issue 137433008: Have HTMLCollection::item() return an Element as per specification (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLSelectElement.h

diff --git a/Source/core/html/HTMLSelectElement.h b/Source/core/html/HTMLSelectElement.h

index 3b8a5e6271cc02df2e474266525f7e6592ebae1d..7d142c225f1444785b702319c9e32d1e7d8579f5 100644

--- a/Source/core/html/HTMLSelectElement.h

+++ b/Source/core/html/HTMLSelectElement.h

@@ -90,8 +90,8 @@ public:

void setOption(unsigned index, HTMLOptionElement*, ExceptionState&);

void setLength(unsigned, ExceptionState&);

- Node* namedItem(const AtomicString& name);

- Node* item(unsigned index);

+ Element* namedItem(const AtomicString& name);

+ Element* item(unsigned index);

void scrollToSelection();

« no previous file with comments | « Source/core/html/HTMLMapElement.cpp ('k') | Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »