Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp - Issue 137433008: Have HTMLCollection::item() return an Element as per specification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp

Issue 137433008: Have HTMLCollection::item() return an Element as per specification (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp

diff --git a/Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp b/Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp

index d337349ba2eefeccf65c3a89a12abcae4685a418..199d33cde91265215f145c122102beb36234ca8a 100644

--- a/Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp

+++ b/Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp

@@ -71,7 +71,7 @@ static v8::Handle<v8::Value> getItem(HTMLAllCollection* collection, v8::Handle<v

return result;

}

- RefPtr<Node> result = collection->item(index->Uint32Value());

+ RefPtr<Element> result = collection->item(index->Uint32Value());

return toV8(result.release(), info.Holder(), info.GetIsolate());

}

« no previous file with comments | « Source/bindings/v8/V8WindowShell.cpp ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »