Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1359163005: Remove surface_id from RenderWidget/RenderWidgetHost and friends (Closed)

Created:
5 years, 3 months ago by piman
Modified:
5 years, 3 months ago
Reviewers:
no sievers, dcheng
CC:
chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, jbauman+watch_chromium.org, kalyank, mcasas+watch_chromium.org, miu+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nona+watch_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, shuchen+watch_chromium.org, sievers+watch_chromium.org, James Su, yusukes+watch_chromium.org, kenrb, lfg
Base URL:
https://chromium.googlesource.com/chromium/src.git@channel_creation_preempt
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove surface_id from RenderWidget/RenderWidgetHost and friends We don't need them any more. BUG=487471 Committed: https://crrev.com/5d36daebe789988bc73b35d122c5401d79d8f322 Cr-Commit-Position: refs/heads/master@{#350686}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase, fix test #

Patch Set 4 : fix more tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -389 lines) Patch
M content/browser/android/in_process/synchronous_compositor_factory_impl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/in_process/synchronous_compositor_factory_impl.cc View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M content/browser/frame_host/frame_tree_node.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/interstitial_page_impl.h View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_factory.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_factory.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 chunks +2 lines, -7 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.h View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 1 2 7 chunks +5 lines, -12 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest_unittest.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M content/browser/gpu/gpu_surface_tracker.h View 2 chunks +1 line, -15 lines 0 comments Download
M content/browser/gpu/gpu_surface_tracker.cc View 2 chunks +3 lines, -34 lines 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_device_client.cc View 3 chunks +7 lines, -12 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 1 chunk +2 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 2 3 chunks +4 lines, -11 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/render_view_host_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_factory.cc View 3 chunks +5 lines, -12 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 4 chunks +3 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_view_host_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_helper.h View 2 chunks +3 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_helper.cc View 4 chunks +9 lines, -24 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 3 chunks +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 5 chunks +0 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 6 chunks +10 lines, -21 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm View 3 chunks +3 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 10 chunks +18 lines, -37 lines 0 comments Download
M content/browser/renderer_host/text_input_client_mac_unittest.mm View 2 chunks +1 line, -5 lines 0 comments Download
M content/browser/security_exploit_browsertest.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 chunks +5 lines, -9 lines 0 comments Download
M content/common/frame_messages.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/view_messages.h View 2 chunks +5 lines, -11 lines 0 comments Download
M content/public/test/mock_render_thread.h View 4 chunks +1 line, -10 lines 0 comments Download
M content/public/test/mock_render_thread.cc View 3 chunks +1 line, -6 lines 0 comments Download
M content/public/test/render_view_test.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/android/synchronous_compositor_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl_browsertest.cc View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 chunks +3 lines, -6 lines 0 comments Download
M content/renderer/render_widget.h View 3 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 6 chunks +12 lines, -14 lines 0 comments Download
M content/renderer/render_widget_fullscreen.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/test_render_frame_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/test_render_frame_host.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/test/test_render_frame_host_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/test_render_frame_host_factory.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/test_render_view_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/test_render_view_host.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/test_render_view_host_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/test_render_view_host_factory.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/test_web_contents.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/test/test_web_contents.cc View 1 chunk +1 line, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (6 generated)
piman
sievers: please review dcheng: OWNERS for *_messages.h
5 years, 3 months ago (2015-09-23 06:37:23 UTC) #2
dcheng
lgtm
5 years, 3 months ago (2015-09-23 21:03:40 UTC) #3
no sievers
LGTM
5 years, 3 months ago (2015-09-23 22:00:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359163005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359163005/20001
5 years, 3 months ago (2015-09-23 23:41:51 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/103142)
5 years, 3 months ago (2015-09-24 00:01:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359163005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359163005/60001
5 years, 3 months ago (2015-09-24 21:14:18 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-24 22:47:17 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 22:47:58 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5d36daebe789988bc73b35d122c5401d79d8f322
Cr-Commit-Position: refs/heads/master@{#350686}

Powered by Google App Engine
This is Rietveld 408576698