Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: content/browser/frame_host/interstitial_page_impl.cc

Issue 1359163005: Remove surface_id from RenderWidget/RenderWidgetHost and friends (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@channel_creation_preempt
Patch Set: fix more tests Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/interstitial_page_impl.cc
diff --git a/content/browser/frame_host/interstitial_page_impl.cc b/content/browser/frame_host/interstitial_page_impl.cc
index ae3c03ea52826671e7332ca52894e217373b6e20..2fe3c900bd63929f17c387d1d0ad4de64f195832 100644
--- a/content/browser/frame_host/interstitial_page_impl.cc
+++ b/content/browser/frame_host/interstitial_page_impl.cc
@@ -594,7 +594,7 @@ RenderViewHostImpl* InterstitialPageImpl::CreateRenderViewHost() {
// Use the RenderViewHost from our FrameTree.
frame_tree_.root()->render_manager()->Init(
browser_context, site_instance.get(), MSG_ROUTING_NONE, MSG_ROUTING_NONE,
- MSG_ROUTING_NONE, 0 /* surface_id */);
+ MSG_ROUTING_NONE);
return frame_tree_.root()->current_frame_host()->render_view_host();
}
@@ -767,14 +767,12 @@ void InterstitialPageImpl::CreateNewWindow(
void InterstitialPageImpl::CreateNewWidget(int32 render_process_id,
int32 route_id,
- int32 surface_id,
blink::WebPopupType popup_type) {
NOTREACHED() << "InterstitialPage does not support showing drop-downs yet.";
}
void InterstitialPageImpl::CreateNewFullscreenWidget(int32 render_process_id,
- int32 route_id,
- int32 surface_id) {
+ int32 route_id) {
NOTREACHED()
<< "InterstitialPage does not support showing full screen popups.";
}
« no previous file with comments | « content/browser/frame_host/interstitial_page_impl.h ('k') | content/browser/frame_host/render_frame_host_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698