content/renderer/render_frame_impl.cc - Issue 1359163005: Remove surface_id from RenderWidget/RenderWidgetHost and friends

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1359163005: Remove surface_id from RenderWidget/RenderWidgetHost and friends (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@channel_creation_preempt

Patch Set: fix more tests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/android/synchronous_compositor_factory.h ('k') | content/renderer/render_frame_impl_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index 1915ee9c45c000dd588a96921a910905efc5b3cd..89ea420bcd2dcfbbd87ae708e18db7c0c358fa9a 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -608,9 +608,8 @@ void RenderFrameImpl::CreateFrame(

if (widget_params.routing_id != MSG_ROUTING_NONE) {

CHECK(SiteIsolationPolicy::AreCrossProcessFramesPossible());

render_frame->render_widget_ = RenderWidget::CreateForFrame(

- widget_params.routing_id, widget_params.surface_id,

- widget_params.hidden, render_frame->render_view_->screen_info(),

- compositor_deps, web_frame);

+ widget_params.routing_id, widget_params.hidden,

+ render_frame->render_view_->screen_info(), compositor_deps, web_frame);

// TODO(kenrb): Observing shouldn't be necessary when we sort out

// WasShown and WasHidden, separating page-level visibility from

// frame-level visibility.

« no previous file with comments | « content/renderer/android/synchronous_compositor_factory.h ('k') | content/renderer/render_frame_impl_browsertest.cc » ('j') | no next file with comments »