content/browser/renderer_host/render_view_host_impl.h - Issue 1359163005: Remove surface_id from RenderWidget/RenderWidgetHost and friends

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 1359163005: Remove surface_id from RenderWidget/RenderWidgetHost and friends (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@channel_creation_preempt

Patch Set: fix more tests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_view_host_factory.cc ('k') | content/browser/renderer_host/render_view_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_impl.h

diff --git a/content/browser/renderer_host/render_view_host_impl.h b/content/browser/renderer_host/render_view_host_impl.h

index e45f07db20fd44994b0f03c6c295c9630bde568a..2a9f31e66ca55c6fa59ff400d70590bca90e38e8 100644

--- a/content/browser/renderer_host/render_view_host_impl.h

+++ b/content/browser/renderer_host/render_view_host_impl.h

@@ -115,7 +115,6 @@ class CONTENT_EXPORT RenderViewHostImpl

RenderViewHostDelegate* delegate,

RenderWidgetHostDelegate* widget_delegate,

int32 routing_id,

- int32 surface_id,

int32 main_frame_routing_id,

bool swapped_out,

bool hidden,

@@ -306,11 +305,10 @@ class CONTENT_EXPORT RenderViewHostImpl

// Creates a new RenderWidget with the given route id. |popup_type| indicates

// if this widget is a popup and what kind of popup it is (select, autofill).

void CreateNewWidget(int32 route_id,

- int32 surface_id,

blink::WebPopupType popup_type);

// Creates a full screen RenderWidget.

- void CreateNewFullscreenWidget(int32 route_id, int32 surface_id);

+ void CreateNewFullscreenWidget(int32 route_id);

void set_main_frame_routing_id(int routing_id) {

main_frame_routing_id_ = routing_id;