Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

Issue 1359163005: Remove surface_id from RenderWidget/RenderWidgetHost and friends (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@channel_creation_preempt
Patch Set: fix more tests Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
index dae4136a014f828eac0b9d269f26f1775f25242a..afeaa5deb135310fcab2ec5a6eaa6f01467f192e 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
@@ -21,7 +21,6 @@
#include "content/browser/compositor/resize_lock.h"
#include "content/browser/compositor/test/no_transport_image_transport_factory.h"
#include "content/browser/frame_host/render_widget_host_view_guest.h"
-#include "content/browser/gpu/gpu_surface_tracker.h"
#include "content/browser/renderer_host/input/input_router.h"
#include "content/browser/renderer_host/input/web_input_event_util.h"
#include "content/browser/renderer_host/overscroll_controller.h"
@@ -389,10 +388,8 @@ class RenderWidgetHostViewAuraTest : public testing::Test {
sink_ = &process_host_->sink();
int32 routing_id = process_host_->GetNextRoutingID();
- int32 surface_id = GpuSurfaceTracker::Get()->AddSurfaceForRenderer(
- process_host_->GetID(), routing_id);
- parent_host_ = new RenderWidgetHostImpl(&delegate_, process_host_,
- routing_id, surface_id, false);
+ parent_host_ =
+ new RenderWidgetHostImpl(&delegate_, process_host_, routing_id, false);
parent_view_ = new RenderWidgetHostViewAura(parent_host_,
is_guest_view_hack_);
parent_view_->InitAsChild(NULL);
@@ -401,10 +398,8 @@ class RenderWidgetHostViewAuraTest : public testing::Test {
gfx::Rect());
routing_id = process_host_->GetNextRoutingID();
- surface_id = GpuSurfaceTracker::Get()->AddSurfaceForRenderer(
- process_host_->GetID(), routing_id);
- widget_host_ = new RenderWidgetHostImpl(&delegate_, process_host_,
- routing_id, surface_id, false);
+ widget_host_ =
+ new RenderWidgetHostImpl(&delegate_, process_host_, routing_id, false);
widget_host_->Init();
view_ = new FakeRenderWidgetHostViewAura(widget_host_, is_guest_view_hack_);
}
@@ -1908,10 +1903,8 @@ TEST_F(RenderWidgetHostViewAuraTest, DiscardDelegatedFrames) {
// Create a bunch of renderers.
for (size_t i = 0; i < renderer_count; ++i) {
int32 routing_id = process_host_->GetNextRoutingID();
- int32 surface_id = GpuSurfaceTracker::Get()->AddSurfaceForRenderer(
- process_host_->GetID(), routing_id);
- hosts[i] = new RenderWidgetHostImpl(&delegate_, process_host_, routing_id,
- surface_id, false);
+ hosts[i] =
+ new RenderWidgetHostImpl(&delegate_, process_host_, routing_id, false);
hosts[i]->Init();
views[i] = new FakeRenderWidgetHostViewAura(hosts[i], false);
views[i]->InitAsChild(NULL);
@@ -2074,10 +2067,8 @@ TEST_F(RenderWidgetHostViewAuraTest, DiscardDelegatedFramesWithLocking) {
// Create a bunch of renderers.
for (size_t i = 0; i < renderer_count; ++i) {
int32 routing_id = process_host_->GetNextRoutingID();
- int32 surface_id = GpuSurfaceTracker::Get()->AddSurfaceForRenderer(
- process_host_->GetID(), routing_id);
- hosts[i] = new RenderWidgetHostImpl(&delegate_, process_host_, routing_id,
- surface_id, false);
+ hosts[i] =
+ new RenderWidgetHostImpl(&delegate_, process_host_, routing_id, false);
hosts[i]->Init();
views[i] = new FakeRenderWidgetHostViewAura(hosts[i], false);
views[i]->InitAsChild(NULL);
@@ -2145,10 +2136,8 @@ TEST_F(RenderWidgetHostViewAuraTest, DiscardDelegatedFramesWithMemoryPressure) {
// Create a bunch of renderers.
for (size_t i = 0; i < renderer_count; ++i) {
int32 routing_id = process_host_->GetNextRoutingID();
- int32 surface_id = GpuSurfaceTracker::Get()->AddSurfaceForRenderer(
- process_host_->GetID(), routing_id);
- hosts[i] = new RenderWidgetHostImpl(&delegate_, process_host_, routing_id,
- surface_id, false);
+ hosts[i] =
+ new RenderWidgetHostImpl(&delegate_, process_host_, routing_id, false);
hosts[i]->Init();
views[i] = new FakeRenderWidgetHostViewAura(hosts[i], false);
views[i]->InitAsChild(NULL);

Powered by Google App Engine
This is Rietveld 408576698