Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1359163005: Remove surface_id from RenderWidget/RenderWidgetHost and friends (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@channel_creation_preempt
Patch Set: fix more tests Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index d87eff2cb6c872997736620d9b1c036e498b6e8f..16e89ef367050c8467f2e46a5e5606bd5fa29da3 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -170,7 +170,6 @@ RenderFrameHostImpl::RenderFrameHostImpl(SiteInstance* site_instance,
FrameTreeNode* frame_tree_node,
int32 routing_id,
int32 widget_routing_id,
- int32 surface_id,
int flags)
: render_view_host_(render_view_host),
delegate_(delegate),
@@ -212,11 +211,9 @@ RenderFrameHostImpl::RenderFrameHostImpl(SiteInstance* site_instance,
&RenderFrameHostImpl::OnSwappedOut, weak_ptr_factory_.GetWeakPtr())));
if (widget_routing_id != MSG_ROUTING_NONE) {
- render_widget_host_ = new RenderWidgetHostImpl(
- rwh_delegate, GetProcess(), widget_routing_id, surface_id, hidden);
+ render_widget_host_ = new RenderWidgetHostImpl(rwh_delegate, GetProcess(),
+ widget_routing_id, hidden);
render_widget_host_->set_owned_by_render_frame_host(true);
- } else {
- DCHECK_EQ(0, surface_id);
}
}
@@ -635,13 +632,11 @@ bool RenderFrameHostImpl::CreateRenderFrame(int proxy_routing_id,
if (render_widget_host_) {
params.widget_params.routing_id = render_widget_host_->GetRoutingID();
- params.widget_params.surface_id = render_widget_host_->surface_id();
params.widget_params.hidden = render_widget_host_->is_hidden();
} else {
// MSG_ROUTING_NONE will prevent a new RenderWidget from being created in
// the renderer process.
params.widget_params.routing_id = MSG_ROUTING_NONE;
- params.widget_params.surface_id = 0;
params.widget_params.hidden = true;
}
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.h ('k') | content/browser/frame_host/render_frame_host_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698