content/browser/security_exploit_browsertest.cc - Issue 1359163005: Remove surface_id from RenderWidget/RenderWidgetHost and friends

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/security_exploit_browsertest.cc

Issue 1359163005: Remove surface_id from RenderWidget/RenderWidgetHost and friends (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@channel_creation_preempt

Patch Set: fix more tests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/text_input_client_mac_unittest.mm ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/security_exploit_browsertest.cc

diff --git a/content/browser/security_exploit_browsertest.cc b/content/browser/security_exploit_browsertest.cc

index 128ea53040e4c92683a1de58bdc03688f311cce2..2c5acc4c48df74d295c899470cd33b4f0c7943b9 100644

--- a/content/browser/security_exploit_browsertest.cc

+++ b/content/browser/security_exploit_browsertest.cc

@@ -236,8 +236,7 @@ IN_PROC_BROWSER_TEST_F(SecurityExploitBrowserTest,

// different timing in the test, let's simulate a CreateNewWidget call coming

// from the IO thread. Use the existing window routing id to cause a

// deliberate collision.

- pending_rvh->CreateNewWidget(duplicate_routing_id, 0 /* surface_id */,

- blink::WebPopupTypePage);

+ pending_rvh->CreateNewWidget(duplicate_routing_id, blink::WebPopupTypePage);

// If the above operation doesn't crash, the test has succeeded!

}