Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: content/browser/renderer_host/render_message_filter.cc

Issue 1359163005: Remove surface_id from RenderWidget/RenderWidgetHost and friends (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@channel_creation_preempt
Patch Set: fix more tests Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_message_filter.cc
diff --git a/content/browser/renderer_host/render_message_filter.cc b/content/browser/renderer_host/render_message_filter.cc
index a05457954b7dbbd362d55227ca12e13f4d384e2f..d59828867501efea76a2013ea99b340c46eec4fc 100644
--- a/content/browser/renderer_host/render_message_filter.cc
+++ b/content/browser/renderer_host/render_message_filter.cc
@@ -229,7 +229,6 @@ void RenderMessageFilter::OnCreateWindow(
const ViewHostMsg_CreateWindow_Params& params,
int* route_id,
int* main_frame_route_id,
- int* surface_id,
int64* cloned_session_storage_namespace_id) {
bool no_javascript_access;
@@ -254,7 +253,6 @@ void RenderMessageFilter::OnCreateWindow(
if (!can_create_window) {
*route_id = MSG_ROUTING_NONE;
*main_frame_route_id = MSG_ROUTING_NONE;
- *surface_id = 0;
*cloned_session_storage_namespace_id = 0;
return;
}
@@ -270,23 +268,18 @@ void RenderMessageFilter::OnCreateWindow(
PeerHandle(),
route_id,
main_frame_route_id,
- surface_id,
cloned_namespace.get());
}
void RenderMessageFilter::OnCreateWidget(int opener_id,
blink::WebPopupType popup_type,
- int* route_id,
- int* surface_id) {
- render_widget_helper_->CreateNewWidget(
- opener_id, popup_type, route_id, surface_id);
+ int* route_id) {
+ render_widget_helper_->CreateNewWidget(opener_id, popup_type, route_id);
}
void RenderMessageFilter::OnCreateFullscreenWidget(int opener_id,
- int* route_id,
- int* surface_id) {
- render_widget_helper_->CreateNewFullscreenWidget(
- opener_id, route_id, surface_id);
+ int* route_id) {
+ render_widget_helper_->CreateNewFullscreenWidget(opener_id, route_id);
}
void RenderMessageFilter::OnGetProcessMemorySizes(size_t* private_bytes,
« no previous file with comments | « content/browser/renderer_host/render_message_filter.h ('k') | content/browser/renderer_host/render_view_host_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698