Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: content/renderer/render_view_impl.cc

Issue 1359163005: Remove surface_id from RenderWidget/RenderWidgetHost and friends (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@channel_creation_preempt
Patch Set: fix more tests Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl_browsertest.cc ('k') | content/renderer/render_widget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 5c2a1871640bb86d3d3fe4adb82ff8fcd7396691..c0ef9d4cee1999455a8a45d2cf484fdad4357c8d 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -667,7 +667,6 @@ RenderViewImpl::RenderViewImpl(CompositorDependencies* compositor_deps,
void RenderViewImpl::Initialize(const ViewMsg_New_Params& params,
bool was_created_by_renderer) {
routing_id_ = params.view_id;
- surface_id_ = params.surface_id;
int opener_view_routing_id;
WebFrame* opener_frame = RenderFrameImpl::ResolveOpener(
@@ -1594,12 +1593,11 @@ WebView* RenderViewImpl::createView(WebLocalFrame* creator,
int32 routing_id = MSG_ROUTING_NONE;
int32 main_frame_routing_id = MSG_ROUTING_NONE;
- int32 surface_id = 0;
int64 cloned_session_storage_namespace_id = 0;
- RenderThread::Get()->Send(new ViewHostMsg_CreateWindow(
- params, &routing_id, &main_frame_routing_id, &surface_id,
- &cloned_session_storage_namespace_id));
+ RenderThread::Get()->Send(
+ new ViewHostMsg_CreateWindow(params, &routing_id, &main_frame_routing_id,
+ &cloned_session_storage_namespace_id));
if (routing_id == MSG_ROUTING_NONE)
return NULL;
@@ -1630,7 +1628,6 @@ WebView* RenderViewImpl::createView(WebLocalFrame* creator,
view_params.web_preferences = webkit_preferences_;
view_params.view_id = routing_id;
view_params.main_frame_routing_id = main_frame_routing_id;
- view_params.surface_id = surface_id;
view_params.session_storage_namespace_id =
cloned_session_storage_namespace_id;
view_params.swapped_out = false;
« no previous file with comments | « content/renderer/render_frame_impl_browsertest.cc ('k') | content/renderer/render_widget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698