Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1575)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1359163005: Remove surface_id from RenderWidget/RenderWidgetHost and friends (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@channel_creation_preempt
Patch Set: fix more tests Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/common/frame_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index e1e3449a00f9c429f755d42757e2421792b3614b..168c201167e332b7d02b1cf71710296cf9c6edb0 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -1352,7 +1352,7 @@ void WebContentsImpl::Init(const WebContents::CreateParams& params) {
params.main_frame_routing_id != MSG_ROUTING_NONE));
GetRenderManager()->Init(params.browser_context, params.site_instance,
params.routing_id, params.main_frame_routing_id,
- MSG_ROUTING_NONE, 0 /* surface_id */);
+ MSG_ROUTING_NONE);
frame_tree_.root()->SetFrameName(params.main_frame_name);
WebContentsViewDelegate* delegate =
@@ -1827,21 +1827,17 @@ void WebContentsImpl::CreateNewWindow(
void WebContentsImpl::CreateNewWidget(int32 render_process_id,
int32 route_id,
- int32 surface_id,
blink::WebPopupType popup_type) {
- CreateNewWidget(render_process_id, route_id, surface_id, false, popup_type);
+ CreateNewWidget(render_process_id, route_id, false, popup_type);
}
void WebContentsImpl::CreateNewFullscreenWidget(int32 render_process_id,
- int32 route_id,
- int32 surface_id) {
- CreateNewWidget(render_process_id, route_id, surface_id, true,
- blink::WebPopupTypeNone);
+ int32 route_id) {
+ CreateNewWidget(render_process_id, route_id, true, blink::WebPopupTypeNone);
}
void WebContentsImpl::CreateNewWidget(int32 render_process_id,
int32 route_id,
- int32 surface_id,
bool is_fullscreen,
blink::WebPopupType popup_type) {
RenderProcessHost* process = GetRenderProcessHost();
@@ -1860,7 +1856,7 @@ void WebContentsImpl::CreateNewWidget(int32 render_process_id,
}
RenderWidgetHostImpl* widget_host =
- new RenderWidgetHostImpl(this, process, route_id, surface_id, IsHidden());
+ new RenderWidgetHostImpl(this, process, route_id, IsHidden());
created_widgets_.insert(widget_host);
RenderWidgetHostViewBase* widget_view =
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/common/frame_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698