content/browser/renderer_host/render_view_host_delegate.h - Issue 1359163005: Remove surface_id from RenderWidget/RenderWidgetHost and friends

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_delegate.h

Issue 1359163005: Remove surface_id from RenderWidget/RenderWidgetHost and friends (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@channel_creation_preempt

Patch Set: fix more tests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_message_filter.cc ('k') | content/browser/renderer_host/render_view_host_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_delegate.h

diff --git a/content/browser/renderer_host/render_view_host_delegate.h b/content/browser/renderer_host/render_view_host_delegate.h

index 904598d3a71442e813d371f91f2c7960e5b49e6f..9a451590f98099a37a86afb20d4c47b29fb4015c 100644

--- a/content/browser/renderer_host/render_view_host_delegate.h

+++ b/content/browser/renderer_host/render_view_host_delegate.h

@@ -227,13 +227,11 @@ class CONTENT_EXPORT RenderViewHostDelegate {

// is (select, autofill...).

virtual void CreateNewWidget(int32 render_process_id,

int32 route_id,

- int32 surface_id,

blink::WebPopupType popup_type) {}

// Creates a full screen RenderWidget. Similar to above.

virtual void CreateNewFullscreenWidget(int32 render_process_id,

- int32 route_id,

- int32 surface_id) {}

+ int32 route_id) {}

// Show a previously created page with the specified disposition and bounds.

// The window is identified by the route_id passed to CreateNewWindow.

« no previous file with comments | « content/browser/renderer_host/render_message_filter.cc ('k') | content/browser/renderer_host/render_view_host_factory.h » ('j') | no next file with comments »