Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: content/common/view_messages.h

Issue 1359163005: Remove surface_id from RenderWidget/RenderWidgetHost and friends (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@channel_creation_preempt
Patch Set: fix more tests Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/frame_messages.h ('k') | content/public/test/mock_render_thread.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/view_messages.h
diff --git a/content/common/view_messages.h b/content/common/view_messages.h
index 41593d1208a1a14648c7e642b5a9c7fb74b6a67c..c4d5983e52199d7ebe1249d2a5ae5861feaa4449 100644
--- a/content/common/view_messages.h
+++ b/content/common/view_messages.h
@@ -485,9 +485,6 @@ IPC_STRUCT_BEGIN(ViewMsg_New_Params)
// The ID of the main frame hosted in the view.
IPC_STRUCT_MEMBER(int32, main_frame_routing_id)
- // The ID of the rendering surface.
- IPC_STRUCT_MEMBER(int32, surface_id)
-
// The session storage namespace ID this view should use.
IPC_STRUCT_MEMBER(int64, session_storage_namespace_id)
@@ -978,28 +975,25 @@ IPC_MESSAGE_ROUTED1(ViewHostMsg_SetNeedsBeginFrames,
// Sent by the renderer when it is creating a new window. The browser creates
// a tab for it and responds with a ViewMsg_CreatingNew_ACK. If route_id is
// MSG_ROUTING_NONE, the view couldn't be created.
-IPC_SYNC_MESSAGE_CONTROL1_4(ViewHostMsg_CreateWindow,
+IPC_SYNC_MESSAGE_CONTROL1_3(ViewHostMsg_CreateWindow,
ViewHostMsg_CreateWindow_Params,
int /* route_id */,
int /* main_frame_route_id */,
- int32 /* surface_id */,
int64 /* cloned_session_storage_namespace_id */)
// Similar to ViewHostMsg_CreateWindow, except used for sub-widgets, like
// <select> dropdowns. This message is sent to the WebContentsImpl that
// contains the widget being created.
-IPC_SYNC_MESSAGE_CONTROL2_2(ViewHostMsg_CreateWidget,
+IPC_SYNC_MESSAGE_CONTROL2_1(ViewHostMsg_CreateWidget,
int /* opener_id */,
blink::WebPopupType /* popup type */,
- int /* route_id */,
- int32 /* surface_id */)
+ int /* route_id */)
// Similar to ViewHostMsg_CreateWidget except the widget is a full screen
// window.
-IPC_SYNC_MESSAGE_CONTROL1_2(ViewHostMsg_CreateFullscreenWidget,
+IPC_SYNC_MESSAGE_CONTROL1_1(ViewHostMsg_CreateFullscreenWidget,
int /* opener_id */,
- int /* route_id */,
- int32 /* surface_id */)
+ int /* route_id */)
// Asks the browser for a unique routing ID.
IPC_SYNC_MESSAGE_CONTROL0_1(ViewHostMsg_GenerateRoutingID,
« no previous file with comments | « content/common/frame_messages.h ('k') | content/public/test/mock_render_thread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698