Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 12326146: Refactor/Rename a bunch of GPU stuff (Closed)

Created:
7 years, 10 months ago by greggman
Modified:
7 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Refactor/Rename a bunch of GPU stuff Remove typedef scoped_refptr<Foo> Ref; FooManager::FooInfo -> Foo Create/Get/RemoveFooInfo to Create/Get//RemoveFoo BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185036

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4862 lines, -4619 lines) Patch
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 3 4 5 66 chunks +144 lines, -127 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper.h View 2 3 4 5 6 chunks +18 lines, -12 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 2 3 4 5 125 chunks +436 lines, -359 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 2 3 4 5 18 chunks +18 lines, -18 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 1 2 3 4 5 18 chunks +18 lines, -18 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 1 2 3 4 5 48 chunks +160 lines, -158 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 1 2 3 4 5 131 chunks +161 lines, -161 lines 0 comments Download
M gpu/command_buffer/client/program_info_manager.cc View 2 3 4 5 17 chunks +26 lines, -26 lines 0 comments Download
M gpu/command_buffer/client/share_group.h View 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format.h View 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 2 3 4 5 276 chunks +523 lines, -473 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager.h View 2 3 4 5 6 chunks +16 lines, -18 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager.cc View 2 3 4 5 10 chunks +17 lines, -17 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager_unittest.cc View 2 3 4 5 11 chunks +27 lines, -27 lines 0 comments Download
M gpu/command_buffer/service/context_group.h View 2 3 4 5 2 chunks +1 line, -3 lines 0 comments Download
M gpu/command_buffer/service/context_group_unittest.cc View 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/context_state.h View 2 3 4 5 4 chunks +14 lines, -13 lines 0 comments Download
M gpu/command_buffer/service/context_state.cc View 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/feature_info.h View 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/feature_info_unittest.cc View 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.h View 2 3 4 5 2 chunks +149 lines, -148 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.cc View 2 3 4 5 26 chunks +50 lines, -49 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager_unittest.cc View 1 2 3 4 5 16 chunks +58 lines, -58 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 5 217 chunks +390 lines, -387 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 1 2 3 4 5 157 chunks +217 lines, -193 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 2 3 4 5 33 chunks +45 lines, -43 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc View 1 2 3 4 5 12 chunks +24 lines, -21 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h View 1 2 3 4 5 128 chunks +423 lines, -410 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc View 1 2 3 4 5 6 chunks +69 lines, -52 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 1 2 3 4 5 140 chunks +360 lines, -341 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 2 3 4 5 2 chunks +13 lines, -13 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 2 3 4 5 29 chunks +50 lines, -47 lines 0 comments Download
M gpu/command_buffer/service/memory_program_cache.h View 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/memory_program_cache.cc View 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/memory_program_cache_unittest.cc View 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/mocks.h View 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/program_cache.h View 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/program_cache_unittest.cc View 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/program_manager.h View 2 3 4 5 4 chunks +241 lines, -239 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 2 3 4 5 46 chunks +64 lines, -63 lines 0 comments Download
M gpu/command_buffer/service/program_manager_unittest.cc View 2 3 4 5 52 chunks +113 lines, -113 lines 0 comments Download
M gpu/command_buffer/service/query_manager.h View 2 3 4 5 2 chunks +2 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/query_manager.cc View 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/query_manager_unittest.cc View 2 3 4 5 12 chunks +14 lines, -14 lines 0 comments Download
M gpu/command_buffer/service/renderbuffer_manager.h View 2 3 4 5 4 chunks +88 lines, -96 lines 0 comments Download
M gpu/command_buffer/service/renderbuffer_manager.cc View 2 3 4 5 7 chunks +26 lines, -13 lines 0 comments Download
M gpu/command_buffer/service/renderbuffer_manager_unittest.cc View 2 3 4 5 6 chunks +26 lines, -26 lines 0 comments Download
M gpu/command_buffer/service/shader_manager.h View 2 3 4 5 2 chunks +166 lines, -165 lines 0 comments Download
M gpu/command_buffer/service/shader_manager.cc View 2 3 4 5 10 chunks +24 lines, -23 lines 0 comments Download
M gpu/command_buffer/service/shader_manager_unittest.cc View 2 3 4 5 14 chunks +29 lines, -29 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 2 3 4 5 6 chunks +315 lines, -314 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 2 3 4 5 50 chunks +72 lines, -72 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 1 2 3 4 5 23 chunks +59 lines, -56 lines 0 comments Download
M gpu/command_buffer/service/vertex_array_manager.cc View 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/vertex_attrib_manager.h View 2 3 4 5 6 chunks +123 lines, -125 lines 0 comments Download
M gpu/command_buffer/service/vertex_attrib_manager.cc View 2 3 4 5 4 chunks +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/vertex_attrib_manager_unittest.cc View 2 3 4 5 7 chunks +24 lines, -24 lines 0 comments Download
M gpu/demos/framework/window.cc View 2 3 4 5 1 chunk +2 lines, -3 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 1 2 3 4 5 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
greggman
Ami, PTAL at content/common/gpu/media Al, PTAL at the rest This is almost entirely search and ...
7 years, 10 months ago (2013-02-27 00:48:37 UTC) #1
Ami GONE FROM CHROMIUM
On 2013/02/27 00:48:37, greggman wrote: > Ami, PTAL at content/common/gpu/media That one file LGTM.
7 years, 9 months ago (2013-02-27 01:37:52 UTC) #2
apatrick_chromium
lgtm
7 years, 9 months ago (2013-02-27 19:20:49 UTC) #3
greggman
7 years, 9 months ago (2013-02-27 21:12:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #6 manually as r185036 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698