Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 107713004: Move all filters-related files from core/platform to platform. (Closed)

Created:
7 years ago by Stephen Chennney
Modified:
7 years ago
CC:
blink-reviews, jamesr, krit, zoltan1, dsinclair, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, danakj, blink-layers+watch_chromium.org, dglazkov+blink, Rik, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, pdr, f(malita), pdr., rwlbuis
Visibility:
Public.

Description

Move all filters-related files from core/platform to platform. Also lots of pre-submit test-related cleanup. R=abarth@chromium.org,senorblanco@chromium.org BUG=303332 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163548

Patch Set 1 #

Patch Set 2 : Fix Android build. #

Patch Set 3 : Fix stupid earlier mistake #

Patch Set 4 : Fixing builds and runhooks, and rebasing #

Patch Set 5 : Export fixes. #

Patch Set 6 : One last export fix #

Patch Set 7 : Maybe fix win build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -9770 lines) Patch
M Source/core/core.gyp View 1 2 3 chunks +0 lines, -39 lines 0 comments Download
M Source/core/core.gypi View 1 2 3 1 chunk +0 lines, -58 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/FilterOperationResolver.cpp View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleResourceLoader.cpp View 2 chunks +1 line, -1 line 0 comments Download
D Source/core/platform/graphics/cpu/arm/filters/FEBlendNEON.h View 1 chunk +0 lines, -174 lines 0 comments Download
D Source/core/platform/graphics/cpu/arm/filters/FECompositeArithmeticNEON.h View 1 chunk +0 lines, -99 lines 0 comments Download
D Source/core/platform/graphics/cpu/arm/filters/FELightingNEON.h View 1 chunk +0 lines, -202 lines 0 comments Download
D Source/core/platform/graphics/filters/DistantLightSource.h View 1 chunk +0 lines, -62 lines 0 comments Download
D Source/core/platform/graphics/filters/DistantLightSource.cpp View 1 chunk +0 lines, -77 lines 0 comments Download
D Source/core/platform/graphics/filters/FEBlend.h View 1 chunk +0 lines, -67 lines 0 comments Download
D Source/core/platform/graphics/filters/FEBlend.cpp View 1 chunk +0 lines, -286 lines 0 comments Download
D Source/core/platform/graphics/filters/FEColorMatrix.h View 1 chunk +0 lines, -99 lines 0 comments Download
D Source/core/platform/graphics/filters/FEColorMatrix.cpp View 1 chunk +0 lines, -334 lines 0 comments Download
D Source/core/platform/graphics/filters/FEComponentTransfer.h View 1 chunk +0 lines, -102 lines 0 comments Download
D Source/core/platform/graphics/filters/FEComponentTransfer.cpp View 1 chunk +0 lines, -283 lines 0 comments Download
D Source/core/platform/graphics/filters/FEComposite.h View 1 chunk +0 lines, -95 lines 0 comments Download
D Source/core/platform/graphics/filters/FEComposite.cpp View 1 chunk +0 lines, -398 lines 0 comments Download
D Source/core/platform/graphics/filters/FEConvolveMatrix.h View 1 chunk +0 lines, -134 lines 0 comments Download
D Source/core/platform/graphics/filters/FEConvolveMatrix.cpp View 1 chunk +0 lines, -570 lines 0 comments Download
D Source/core/platform/graphics/filters/FEDiffuseLighting.h View 1 chunk +0 lines, -64 lines 0 comments Download
D Source/core/platform/graphics/filters/FEDiffuseLighting.cpp View 1 chunk +0 lines, -136 lines 0 comments Download
D Source/core/platform/graphics/filters/FEDisplacementMap.h View 1 chunk +0 lines, -75 lines 0 comments Download
D Source/core/platform/graphics/filters/FEDisplacementMap.cpp View 1 chunk +0 lines, -262 lines 0 comments Download
D Source/core/platform/graphics/filters/FEDropShadow.h View 1 chunk +0 lines, -75 lines 0 comments Download
D Source/core/platform/graphics/filters/FEDropShadow.cpp View 1 chunk +0 lines, -147 lines 0 comments Download
D Source/core/platform/graphics/filters/FEFlood.h View 1 chunk +0 lines, -64 lines 0 comments Download
D Source/core/platform/graphics/filters/FEFlood.cpp View 1 chunk +0 lines, -107 lines 0 comments Download
D Source/core/platform/graphics/filters/FELighting.h View 1 chunk +0 lines, -128 lines 0 comments Download
D Source/core/platform/graphics/filters/FELighting.cpp View 1 chunk +0 lines, -489 lines 0 comments Download
D Source/core/platform/graphics/filters/FEMerge.h View 1 chunk +0 lines, -48 lines 0 comments Download
D Source/core/platform/graphics/filters/FEMerge.cpp View 1 chunk +0 lines, -88 lines 0 comments Download
D Source/core/platform/graphics/filters/FEMorphology.h View 1 chunk +0 lines, -91 lines 0 comments Download
D Source/core/platform/graphics/filters/FEMorphology.cpp View 1 chunk +0 lines, -305 lines 0 comments Download
D Source/core/platform/graphics/filters/FEOffset.h View 1 chunk +0 lines, -59 lines 0 comments Download
D Source/core/platform/graphics/filters/FEOffset.cpp View 1 chunk +0 lines, -126 lines 0 comments Download
D Source/core/platform/graphics/filters/FESpecularLighting.h View 1 chunk +0 lines, -65 lines 0 comments Download
D Source/core/platform/graphics/filters/FESpecularLighting.cpp View 1 chunk +0 lines, -151 lines 0 comments Download
D Source/core/platform/graphics/filters/FETile.h View 1 chunk +0 lines, -51 lines 0 comments Download
D Source/core/platform/graphics/filters/FETile.cpp View 1 chunk +0 lines, -105 lines 0 comments Download
D Source/core/platform/graphics/filters/FETurbulence.h View 1 chunk +0 lines, -140 lines 0 comments Download
D Source/core/platform/graphics/filters/FETurbulence.cpp View 1 chunk +0 lines, -474 lines 0 comments Download
D Source/core/platform/graphics/filters/PointLightSource.h View 1 chunk +0 lines, -59 lines 0 comments Download
D Source/core/platform/graphics/filters/PointLightSource.cpp View 1 chunk +0 lines, -88 lines 0 comments Download
D Source/core/platform/graphics/filters/SourceAlpha.h View 1 chunk +0 lines, -52 lines 0 comments Download
D Source/core/platform/graphics/filters/SourceAlpha.cpp View 1 chunk +0 lines, -75 lines 0 comments Download
D Source/core/platform/graphics/filters/SpotLightSource.h View 1 chunk +0 lines, -78 lines 0 comments Download
D Source/core/platform/graphics/filters/SpotLightSource.cpp View 1 chunk +0 lines, -195 lines 0 comments Download
D Source/core/platform/graphics/filters/custom/CustomFilterCompiledProgram.h View 1 chunk +0 lines, -95 lines 0 comments Download
D Source/core/platform/graphics/filters/custom/CustomFilterCompiledProgram.cpp View 1 chunk +0 lines, -149 lines 0 comments Download
D Source/core/platform/graphics/filters/custom/CustomFilterGlobalContext.h View 1 chunk +0 lines, -81 lines 0 comments Download
D Source/core/platform/graphics/filters/custom/CustomFilterGlobalContext.cpp View 1 chunk +0 lines, -113 lines 0 comments Download
D Source/core/platform/graphics/filters/custom/CustomFilterMesh.h View 1 chunk +0 lines, -76 lines 0 comments Download
D Source/core/platform/graphics/filters/custom/CustomFilterMesh.cpp View 1 chunk +0 lines, -68 lines 0 comments Download
D Source/core/platform/graphics/filters/custom/CustomFilterOperation.h View 1 chunk +0 lines, -97 lines 0 comments Download
D Source/core/platform/graphics/filters/custom/CustomFilterOperation.cpp View 1 chunk +0 lines, -74 lines 0 comments Download
D Source/core/platform/graphics/filters/custom/CustomFilterProgram.h View 1 chunk +0 lines, -92 lines 0 comments Download
D Source/core/platform/graphics/filters/custom/CustomFilterProgram.cpp View 1 chunk +0 lines, -85 lines 0 comments Download
D Source/core/platform/graphics/filters/custom/CustomFilterRenderer.h View 1 chunk +0 lines, -98 lines 0 comments Download
D Source/core/platform/graphics/filters/custom/CustomFilterRenderer.cpp View 1 chunk +0 lines, -292 lines 0 comments Download
D Source/core/platform/graphics/filters/custom/CustomFilterValidatedProgram.h View 1 chunk +0 lines, -123 lines 0 comments Download
D Source/core/platform/graphics/filters/custom/CustomFilterValidatedProgram.cpp View 1 chunk +0 lines, -616 lines 0 comments Download
D Source/core/platform/graphics/filters/custom/FECustomFilter.h View 1 chunk +0 lines, -101 lines 0 comments Download
D Source/core/platform/graphics/filters/custom/FECustomFilter.cpp View 1 chunk +0 lines, -368 lines 0 comments Download
D Source/core/platform/graphics/filters/custom/ValidatedCustomFilterOperation.h View 1 chunk +0 lines, -93 lines 0 comments Download
D Source/core/platform/graphics/filters/custom/ValidatedCustomFilterOperation.cpp View 1 2 3 1 chunk +0 lines, -60 lines 0 comments Download
M Source/core/rendering/CompositedLayerMapping.cpp View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M Source/core/rendering/FilterEffectRenderer.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderLayerFilterInfo.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderView.cpp View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M Source/core/rendering/style/StyleCustomFilterProgram.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/ReferenceFilterBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGComponentTransferFunctionElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEBlendElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEColorMatrixElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEComponentTransferElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFECompositeElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEConvolveMatrixElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEDiffuseLightingElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEDisplacementMapElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEDistantLightElement.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFEDropShadowElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEFloodElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEMergeElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEMorphologyElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEOffsetElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEPointLightElement.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFESpecularLightingElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFESpotLightElement.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFETileElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFETurbulenceElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/graphics/filters/SVGFilterBuilder.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/platform/blink_platform.gyp View 1 2 3 2 chunks +35 lines, -0 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 2 3 2 chunks +61 lines, -0 lines 0 comments Download
A + Source/platform/graphics/cpu/arm/filters/FEBlendNEON.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/graphics/cpu/arm/filters/FECompositeArithmeticNEON.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/graphics/cpu/arm/filters/FELightingNEON.h View 3 chunks +5 lines, -4 lines 0 comments Download
A + Source/platform/graphics/filters/DistantLightSource.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/graphics/filters/DistantLightSource.cpp View 1 chunk +1 line, -2 lines 0 comments Download
A + Source/platform/graphics/filters/FEBlend.h View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
A + Source/platform/graphics/filters/FEBlend.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
A + Source/platform/graphics/filters/FEColorMatrix.h View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
A + Source/platform/graphics/filters/FEColorMatrix.cpp View 3 chunks +13 lines, -15 lines 0 comments Download
A + Source/platform/graphics/filters/FEComponentTransfer.h View 1 2 3 3 chunks +4 lines, -5 lines 0 comments Download
A + Source/platform/graphics/filters/FEComponentTransfer.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
A + Source/platform/graphics/filters/FEComposite.h View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
A + Source/platform/graphics/filters/FEComposite.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/platform/graphics/filters/FEConvolveMatrix.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/graphics/filters/FEConvolveMatrix.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
A + Source/platform/graphics/filters/FEDiffuseLighting.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/platform/graphics/filters/FEDiffuseLighting.cpp View 1 chunk +1 line, -2 lines 0 comments Download
A + Source/platform/graphics/filters/FEDisplacementMap.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/graphics/filters/FEDisplacementMap.cpp View 2 chunks +5 lines, -7 lines 0 comments Download
A + Source/platform/graphics/filters/FEDropShadow.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/graphics/filters/FEDropShadow.cpp View 1 chunk +1 line, -3 lines 0 comments Download
A + Source/platform/graphics/filters/FEFlood.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/graphics/filters/FEFlood.cpp View 1 chunk +1 line, -2 lines 0 comments Download
A + Source/platform/graphics/filters/FELighting.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + Source/platform/graphics/filters/FELighting.cpp View 6 chunks +10 lines, -14 lines 0 comments Download
A + Source/platform/graphics/filters/FEMerge.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/graphics/filters/FEMerge.cpp View 1 chunk +1 line, -2 lines 0 comments Download
A + Source/platform/graphics/filters/FEMorphology.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/graphics/filters/FEMorphology.cpp View 3 chunks +5 lines, -9 lines 0 comments Download
A + Source/platform/graphics/filters/FEOffset.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/graphics/filters/FEOffset.cpp View 1 chunk +1 line, -2 lines 0 comments Download
A + Source/platform/graphics/filters/FESpecularLighting.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/platform/graphics/filters/FESpecularLighting.cpp View 1 chunk +1 line, -2 lines 0 comments Download
A + Source/platform/graphics/filters/FETile.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/graphics/filters/FETile.cpp View 1 chunk +1 line, -2 lines 0 comments Download
A + Source/platform/graphics/filters/FETurbulence.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/graphics/filters/FETurbulence.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/graphics/filters/PointLightSource.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/graphics/filters/PointLightSource.cpp View 1 chunk +1 line, -2 lines 0 comments Download
A + Source/platform/graphics/filters/SourceAlpha.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + Source/platform/graphics/filters/SourceAlpha.cpp View 1 chunk +1 line, -2 lines 0 comments Download
A + Source/platform/graphics/filters/SpotLightSource.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/graphics/filters/SpotLightSource.cpp View 1 chunk +1 line, -2 lines 0 comments Download
A + Source/platform/graphics/filters/custom/CustomFilterCompiledProgram.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/graphics/filters/custom/CustomFilterCompiledProgram.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/graphics/filters/custom/CustomFilterGlobalContext.h View 1 2 3 4 5 6 2 chunks +3 lines, -1 line 0 comments Download
A + Source/platform/graphics/filters/custom/CustomFilterGlobalContext.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
A + Source/platform/graphics/filters/custom/CustomFilterMesh.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/platform/graphics/filters/custom/CustomFilterMesh.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/graphics/filters/custom/CustomFilterOperation.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/platform/graphics/filters/custom/CustomFilterOperation.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/graphics/filters/custom/CustomFilterProgram.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/graphics/filters/custom/CustomFilterProgram.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/graphics/filters/custom/CustomFilterRenderer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/graphics/filters/custom/CustomFilterRenderer.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + Source/platform/graphics/filters/custom/CustomFilterValidatedProgram.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
A + Source/platform/graphics/filters/custom/CustomFilterValidatedProgram.cpp View 2 chunks +9 lines, -8 lines 0 comments Download
A + Source/platform/graphics/filters/custom/FECustomFilter.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
A + Source/platform/graphics/filters/custom/FECustomFilter.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
A + Source/platform/graphics/filters/custom/ValidatedCustomFilterOperation.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/graphics/filters/custom/ValidatedCustomFilterOperation.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/tests/ImageFilterBuilderTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Stephen Chennney
7 years ago (2013-12-09 21:13:37 UTC) #1
abarth-chromium
rsLGTM
7 years ago (2013-12-09 21:29:07 UTC) #2
Stephen White
RSLGTM too (once you've pleased the CQ)
7 years ago (2013-12-10 00:38:14 UTC) #3
Stephen Chennney
On 2013/12/10 00:38:14, Stephen White wrote: > RSLGTM too (once you've pleased the CQ) Yeah. ...
7 years ago (2013-12-10 00:51:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/schenney@chromium.org/107713004/100001
7 years ago (2013-12-10 01:45:26 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout&number=15188
7 years ago (2013-12-10 03:18:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/schenney@chromium.org/107713004/110001
7 years ago (2013-12-10 13:22:34 UTC) #7
commit-bot: I haz the power
Failed to trigger a try job on win_layout HTTP Error 400: Bad Request
7 years ago (2013-12-10 15:56:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/schenney@chromium.org/107713004/140001
7 years ago (2013-12-10 16:55:21 UTC) #9
commit-bot: I haz the power
7 years ago (2013-12-10 18:12:26 UTC) #10
Message was sent while issue was closed. 
Change committed as 163548

Powered by Google App Engine
This is Rietveld 408576698