pathops version two

pathops version two

R=reed@google.com

marked 'no commit' to attempt to get trybots to run

TBR=reed@google.com

Committed: https://skia.googlesource.com/skia/+/ccec0f958ffc71a9986d236bc2eb335cb2111119

[caryclark, 2015-03-19 21:14:06]

The CQ bit was checked by caryclark@google.com

[commit-bot: I haz the power, 2015-03-19 21:19:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1002693002/90001

[commit-bot: I haz the power, 2015-03-19 21:19:51]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-03-20 03:19 UTC

[commit-bot: I haz the power, 2015-03-19 21:21:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-19 21:21:27]

Presubmit check for 1002693002-90001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')

[caryclark, 2015-03-23 20:17:44]

The CQ bit was checked by caryclark@google.com

[commit-bot: I haz the power, 2015-03-23 20:18:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1002693002/130001

[commit-bot: I haz the power, 2015-03-23 20:20:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-23 20:20:41]

Try jobs failed on following builders:
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[reed1, 2015-03-23 20:22:16]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2015-03-23 20:22:18]

lgtm

[caryclark, 2015-03-23 20:29:19]

The CQ bit was checked by caryclark@google.com

[caryclark, 2015-03-23 20:29:20]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1002693002/#ps140001
(title: "fix linux warning")

[caryclark, 2015-03-23 20:29:29]

The CQ bit was unchecked by caryclark@google.com

[caryclark, 2015-03-23 20:30:53]

The CQ bit was checked by caryclark@google.com

[commit-bot: I haz the power, 2015-03-23 20:31:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1002693002/140001

[caryclark, 2015-03-23 20:31:42]

The CQ bit was unchecked by caryclark@google.com

[caryclark, 2015-03-24 14:21:40]

The CQ bit was checked by caryclark@google.com

[caryclark, 2015-03-24 14:21:42]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1002693002/#ps150001
(title: "fix arm 64 inspired coincident handling")

[commit-bot: I haz the power, 2015-03-24 14:21:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1002693002/150001

[commit-bot: I haz the power, 2015-03-24 14:28:23]

Committed patchset #16 (id:150001) as
https://skia.googlesource.com/skia/+/ccec0f958ffc71a9986d236bc2eb335cb2111119

[reed1, 2015-03-24 20:54:19]

A revert of this CL (patchset #16 id:150001) has been created in
https://codereview.chromium.org/1029993002/ by reed@google.com.

The reason for reverting is: ASAN investigation.

[brucedawson, 2015-03-25 20:54:24]

The VC++ /analyze bot has pointed out a bug in this change. I don't know if it
is related to the ASAN investigation.

The relevant warnings are:

skia\src\pathops\skopedgebuilder.cpp(211) : warning C6295: Ill-defined for-loop:
 'unsigned int' values are always of range '0' to '4294967295'.  Loop executes
infinitely.
skia\src\pathops\skopedgebuilder.cpp(211) : warning C6384: Dividing sizeof a
pointer by another value.

The first warning is a bit cryptic, and is actually worded incorrectly. The
second warning points out the real problem.

The expression "SK_ARRAY_COUNT(curve1)" is invalid because SK_ARRAY_COUNT is
designed to work on arrays and curve1 is a pointer. It therefore always returns
an array count of (I believe) zero, leading to the loop never running.

I opened a bug suggesting that SK_ARRAY_COUNT should be made safe:
https://code.google.com/p/skia/issues/detail?id=3593

I assume that the incorrect loop in skopedgebuilder.cpp will be fixed when this
change is resubmitted.