Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7795063: Changes for l10n in official build. (Closed)

Created:
9 years, 3 months ago by Jamie
Modified:
9 years, 3 months ago
Reviewers:
garykac
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Changes for l10n in official build. BUG=87821 TEST=Try the app in another language. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100191

Patch Set 1 #

Patch Set 2 : Fixed non-ASCII characters. #

Patch Set 3 : Fixed bad unicode char encoding. #

Total comments: 1

Patch Set 4 : Incorporated comments from garykac@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -10 lines) Patch
M remoting/remoting.gyp View 2 chunks +50 lines, -3 lines 0 comments Download
M remoting/webapp/build-webapp.py View 1 2 3 1 chunk +8 lines, -2 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/ar/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/bg/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/ca/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/cs/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/da/messages.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/de/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/el/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/en/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/en_GB/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/es/messages.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/es_419/messages.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/et/messages.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/fi/messages.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/fil/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/fr/messages.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/he/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/hi/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/hr/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/hu/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/id/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/it/messages.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/ja/messages.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/ko/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/lt/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/lv/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/nb/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/nl/messages.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/pl/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/pt_BR/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/pt_PT/messages.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/ro/messages.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/ru/messages.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/sk/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/sl/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/sr/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/sv/messages.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/th/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/tr/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/uk/messages.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/vi/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/zh_CN/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/me2mom/_locales.official/zh_TW/messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
M remoting/webapp/me2mom/_locales/en/messages.json View 1 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jamie
Here's the framework for building the official (localized) build. Some of the strings need tweaking, ...
9 years, 3 months ago (2011-09-07 21:27:56 UTC) #1
garykac
9 years, 3 months ago (2011-09-08 17:18:34 UTC) #2 
LGTM

http://codereview.chromium.org/7795063/diff/3047/remoting/webapp/build-webapp.py
File remoting/webapp/build-webapp.py (right):

http://codereview.chromium.org/7795063/diff/3047/remoting/webapp/build-webapp...
remoting/webapp/build-webapp.py:107: len = 10
Would it be better to strlen("/locales/") here rather than hard-coding 10?

Powered by Google App Engine
This is Rietveld 408576698