Issue 151101: Fixit: Remove bunch of coverity warnings from chrome/installer/*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151101: Fixit: Remove bunch of coverity warnings from chrome/installer/*. (Closed)

Created:
11 years, 5 months ago by kuchhal

Modified:
9 years, 7 months ago

Reviewers:
huanr

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fixit: Remove bunch of coverity warnings from chrome/installer/*. BUg=12849

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+198 lines, -147 lines)			Patch
M	chrome/installer/gcapi/gcapi.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/installer/setup/install.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/installer/setup/uninstall.cc	View	2 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/installer/util/copy_tree_work_item.h	View	3 chunks	+10 lines, -8 lines	0 comments	Download
M	chrome/installer/util/copy_tree_work_item.cc	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/installer/util/copy_tree_work_item_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/installer/util/create_reg_key_work_item.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/installer/util/create_reg_key_work_item.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/installer/util/delete_reg_value_work_item.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/installer/util/delete_reg_value_work_item.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/installer/util/delete_tree_work_item.h	View	3 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/installer/util/delete_tree_work_item.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/installer/util/google_chrome_distribution_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/installer/util/l10n_string_util.cc	View	2 chunks	+9 lines, -2 lines	0 comments	Download
M	chrome/installer/util/lzma_util.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/installer/util/set_reg_value_work_item.h	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/installer/util/set_reg_value_work_item.cc	View	2 chunks	+14 lines, -11 lines	0 comments	Download
M	chrome/installer/util/version.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/installer/util/version.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/installer/util/work_item.h	View	2 chunks	+27 lines, -16 lines	0 comments	Download
M	chrome/installer/util/work_item.cc	View	2 chunks	+29 lines, -18 lines	0 comments	Download
M	chrome/installer/util/work_item_list.h	View	3 chunks	+27 lines, -18 lines	0 comments	Download
M	chrome/installer/util/work_item_list.cc	View	4 chunks	+19 lines, -19 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM. It seems Coverity does find 2 bugs.

Expand Messages | Collapse Messages