Fixit: Remove bunch of coverity warnings from chrome/installer/*.

chrome/installer/util/l10n_string_util.cc

+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+// This file defines specific implementation of BrowserDistribution class for
+// Google Chrome.
+
 #include <atlbase.h>
 #include <shlwapi.h>
 
 #include <map>
 
 #include "base/logging.h"
 #include "base/scoped_ptr.h"
 #include "base/string_util.h"
 
 #include "installer_util_strings.h"
@@ skipping 148 matching lines @@
     NOTREACHED() << "Unable to find resource id " << message_id;
   }
 
   return localized_string;
 }
 
 // Here we generate the url spec with the Microsoft res:// scheme which is
 // explained here : http://support.microsoft.com/kb/220830
 std::wstring GetLocalizedEulaResource() {
   wchar_t full_exe_path[MAX_PATH];
-  int len = ::GetModuleFileNameW(NULL, full_exe_path, MAX_PATH);
-  if (len <= 0 && len >= MAX_PATH)
+  int len = ::GetModuleFileName(NULL, full_exe_path, MAX_PATH);
+  if (len == 0 || len == MAX_PATH)
     return L"";
   std::wstring language = GetSystemLanguage();
   const wchar_t* resource = L"IDR_OEMPG_EN.HTML";
 
   static std::map<int, wchar_t*> html_map;
   if (html_map.empty()) {
     html_map[IDS_L10N_OFFSET_AR] = L"IDR_OEMPG_AR.HTML";
     html_map[IDS_L10N_OFFSET_BG] = L"IDR_OEMPG_BG.HTML";
     html_map[IDS_L10N_OFFSET_CA] = L"IDR_OEMPG_CA.HTML";
     html_map[IDS_L10N_OFFSET_CS] = L"IDR_OEMPG_CS.HTML";
@@ skipping 47 matching lines @@
   DWORD count = url_path.size() * 3;
   scoped_ptr<wchar_t> url_canon(new wchar_t[count]);
   HRESULT hr = ::UrlCanonicalizeW(url_path.c_str(), url_canon.get(),
                                   &count, URL_ESCAPE_UNSAFE);
   if (SUCCEEDED(hr))
     return std::wstring(url_canon.get());
   return url_path;
 }
 
 }  // namespace installer_util