Fixit: Remove bunch of coverity warnings from chrome/installer/*.

chrome/installer/util/version.cc

-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/string_util.h"
 #include "chrome/installer/util/version.h"
 
 installer::Version::Version(int64 major, int64 minor, int64 build,
                             int64 patch) :
@@ skipping 14 matching lines @@
   return ((major_ > other->major_) ||
           ((major_ == other->major_) && (minor_ > other->minor_)) ||
           ((major_ == other->major_) && (minor_ == other->minor_)
                                      && (build_ > other->build_)) ||
           ((major_ == other->major_) && (minor_ == other->minor_)
                                      && (build_ == other->build_)
                                      && (patch_ > other->patch_)));
 }
 
 installer::Version* installer::Version::GetVersionFromString(
-    std::wstring version_str) {
+    const std::wstring& version_str) {
   std::vector<std::wstring> numbers;
   SplitString(version_str, '.', &numbers);
 
   if (numbers.size() != 4) {
     return NULL;
   }
 
   return new Version(StringToInt64(numbers[0]), StringToInt64(numbers[1]),
                      StringToInt64(numbers[2]), StringToInt64(numbers[3]));
 }