Fixit: Remove bunch of coverity warnings from chrome/installer/*.

chrome/installer/util/google_chrome_distribution_unittest.cc

-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Unit tests for GoogleChromeDistribution class.
 
 #include <windows.h>
 
 #include "base/registry.h"
 #include "base/scoped_ptr.h"
 #include "base/file_util.h"
@@ skipping 12 matching lines @@
   virtual void SetUp() {
     // Currently no setup required.
   }
 
   virtual void TearDown() {
     // Currently no tear down required.
   }
 
   // Creates "ap" key with the value given as parameter. Also adds work
   // items to work_item_list given so that they can be rolled back later.
-  bool CreateApKey(WorkItemList* work_item_list, std::wstring value) {
+  bool CreateApKey(WorkItemList* work_item_list, const std::wstring& value) {
     HKEY reg_root = HKEY_CURRENT_USER;
     std::wstring reg_key = GetApKeyPath();
     work_item_list->AddCreateRegKeyWorkItem(reg_root, reg_key);
     work_item_list->AddSetRegValueWorkItem(reg_root, reg_key,
         google_update::kRegApField, value.c_str(), true);
     if (!work_item_list->Do()) {
       work_item_list->Rollback();
       return false;
     }
     return true;
@@ skipping 275 matching lines @@
 
   EXPECT_TRUE(file_util::WriteFile(prefs, text, sizeof(text)));
   typedef std::vector<std::wstring> TabsVector;
   TabsVector tabs = installer_util::ParseFirstRunTabs(prefs);
   ASSERT_EQ(3, tabs.size());
   EXPECT_EQ(L"http://google.com/f1", tabs[0]);
   EXPECT_EQ(L"https://google.com/f2", tabs[1]);
   EXPECT_EQ(L"new_tab_page", tabs[2]);
   EXPECT_TRUE(file_util::Delete(prefs, false));
 }