Fixit: Remove bunch of coverity warnings from chrome/installer/*.

chrome/installer/util/work_item_list.cc

Index: chrome/installer/util/work_item_list.cc
diff --git a/chrome/installer/util/work_item_list.cc b/chrome/installer/util/work_item_list.cc
index e5aa3bcae0ba785ba274c351e8d37298e2e154a0..3e5ac076162dbf69f5f67310bb0218d9f09cc2e8 100644
--- a/chrome/installer/util/work_item_list.cc
+++ b/chrome/installer/util/work_item_list.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -63,33 +63,33 @@ bool WorkItemList::AddWorkItem(WorkItem* work_item) {
   return true;
 }
 
-bool WorkItemList::AddCopyTreeWorkItem(std::wstring source_path,
-                                       std::wstring dest_path,
-                                       std::wstring temp_dir,
+bool WorkItemList::AddCopyTreeWorkItem(const std::wstring& source_path,
+                                       const std::wstring& dest_path,
+                                       const std::wstring& temp_dir,
                                        CopyOverWriteOption overwrite_option,
-                                       std::wstring alternative_path) {
+                                       const std::wstring& alternative_path) {
   WorkItem* item = reinterpret_cast<WorkItem*>(
       WorkItem::CreateCopyTreeWorkItem(source_path, dest_path, temp_dir,
                                        overwrite_option, alternative_path));
   return AddWorkItem(item);
 }
 
-bool WorkItemList::AddCreateDirWorkItem(std::wstring path) {
+bool WorkItemList::AddCreateDirWorkItem(const std::wstring& path) {
   WorkItem* item = reinterpret_cast<WorkItem*>(
       WorkItem::CreateCreateDirWorkItem(path));
   return AddWorkItem(item);
 }
 
 bool WorkItemList::AddCreateRegKeyWorkItem(HKEY predefined_root,
-                                           std::wstring path) {
+                                           const std::wstring& path) {
   WorkItem* item = reinterpret_cast<WorkItem*>(
       WorkItem::CreateCreateRegKeyWorkItem(predefined_root, path));
   return AddWorkItem(item);
 }
 
 bool WorkItemList::AddDeleteRegValueWorkItem(HKEY predefined_root,
-                                             std::wstring key_path,
-                                             std::wstring value_name,
+                                             const std::wstring& key_path,
+                                             const std::wstring& value_name,
                                              bool is_str_type) {
   WorkItem* item = reinterpret_cast<WorkItem*>(
       WorkItem::CreateDeleteRegValueWorkItem(predefined_root, key_path,
@@ -97,25 +97,25 @@ bool WorkItemList::AddDeleteRegValueWorkItem(HKEY predefined_root,
   return AddWorkItem(item);
 }
 
-bool WorkItemList::AddDeleteTreeWorkItem(std::wstring root_path,
-                                         std::wstring key_path) {
+bool WorkItemList::AddDeleteTreeWorkItem(const std::wstring& root_path,
+                                         const std::wstring& key_path) {
   WorkItem* item = reinterpret_cast<WorkItem*>(
       WorkItem::CreateDeleteTreeWorkItem(root_path, key_path));
   return AddWorkItem(item);
 }
 
-bool WorkItemList::AddMoveTreeWorkItem(std::wstring source_path,
-                                       std::wstring dest_path,
-                                       std::wstring temp_dir) {
+bool WorkItemList::AddMoveTreeWorkItem(const std::wstring& source_path,
+                                       const std::wstring& dest_path,
+                                       const std::wstring& temp_dir) {
   WorkItem* item = reinterpret_cast<WorkItem*>(
       WorkItem::CreateMoveTreeWorkItem(source_path, dest_path, temp_dir));
   return AddWorkItem(item);
 }
 
 bool WorkItemList::AddSetRegValueWorkItem(HKEY predefined_root,
-                                          std::wstring key_path,
-                                          std::wstring value_name,
-                                          std::wstring value_data,
+                                          const std::wstring& key_path,
+                                          const std::wstring& value_name,
+                                          const std::wstring& value_data,
                                           bool overwrite) {
   WorkItem* item = reinterpret_cast<WorkItem*>(
       WorkItem::CreateSetRegValueWorkItem(predefined_root, key_path, value_name,
@@ -124,8 +124,8 @@ bool WorkItemList::AddSetRegValueWorkItem(HKEY predefined_root,
 }
 
 bool WorkItemList::AddSetRegValueWorkItem(HKEY predefined_root,
-                                          std::wstring key_path,
-                                          std::wstring value_name,
+                                          const std::wstring& key_path,
+                                          const std::wstring& value_name,
                                           DWORD value_data,
                                           bool overwrite) {
   WorkItem* item = reinterpret_cast<WorkItem*>(