Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Unified Diff: chrome/installer/util/set_reg_value_work_item.cc

Issue 151101: Fixit: Remove bunch of coverity warnings from chrome/installer/*. (Closed)
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/set_reg_value_work_item.h ('k') | chrome/installer/util/version.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/set_reg_value_work_item.cc
diff --git a/chrome/installer/util/set_reg_value_work_item.cc b/chrome/installer/util/set_reg_value_work_item.cc
index 57965d0e75b6d8835dba5354ce0ca9a02166f083..74c8d2c46542dba750c4f457f95003e21257f7a3 100644
--- a/chrome/installer/util/set_reg_value_work_item.cc
+++ b/chrome/installer/util/set_reg_value_work_item.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -10,31 +10,34 @@ SetRegValueWorkItem::~SetRegValueWorkItem() {
}
SetRegValueWorkItem::SetRegValueWorkItem(HKEY predefined_root,
- std::wstring key_path,
- std::wstring value_name,
- std::wstring value_data,
- bool overwrite)
+ const std::wstring& key_path,
+ const std::wstring& value_name,
+ const std::wstring& value_data,
+ bool overwrite)
: predefined_root_(predefined_root),
key_path_(key_path),
value_name_(value_name),
value_data_str_(value_data),
+ value_data_dword_(0),
overwrite_(overwrite),
status_(SET_VALUE),
- is_str_type_(true) {
+ is_str_type_(true),
+ previous_value_dword_(0) {
}
SetRegValueWorkItem::SetRegValueWorkItem(HKEY predefined_root,
- std::wstring key_path,
- std::wstring value_name,
- DWORD value_data,
- bool overwrite)
+ const std::wstring& key_path,
+ const std::wstring& value_name,
+ DWORD value_data,
+ bool overwrite)
: predefined_root_(predefined_root),
key_path_(key_path),
value_name_(value_name),
value_data_dword_(value_data),
overwrite_(overwrite),
status_(SET_VALUE),
- is_str_type_(false) {
+ is_str_type_(false),
+ previous_value_dword_(0) {
}
bool SetRegValueWorkItem::Do() {
« no previous file with comments | « chrome/installer/util/set_reg_value_work_item.h ('k') | chrome/installer/util/version.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698