Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5340)

Unified Diff: chrome/installer/util/set_reg_value_work_item.h

Issue 151101: Fixit: Remove bunch of coverity warnings from chrome/installer/*. (Closed)
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/lzma_util.cc ('k') | chrome/installer/util/set_reg_value_work_item.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/set_reg_value_work_item.h
diff --git a/chrome/installer/util/set_reg_value_work_item.h b/chrome/installer/util/set_reg_value_work_item.h
index 1dd48697ac9e838a444c08122e27515146910035..7eac8955365bee147ca7d48d7ff707cd9c9ed627 100644
--- a/chrome/installer/util/set_reg_value_work_item.h
+++ b/chrome/installer/util/set_reg_value_work_item.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -38,12 +38,14 @@ class SetRegValueWorkItem : public WorkItem {
VALUE_ROLL_BACK
};
- SetRegValueWorkItem(HKEY predefined_root, std::wstring key_path,
- std::wstring value_name, std::wstring value_data,
+ SetRegValueWorkItem(HKEY predefined_root,
+ const std::wstring& key_path,
+ const std::wstring& value_name,
+ const std::wstring& value_data,
bool overwrite);
- SetRegValueWorkItem(HKEY predefined_root, std::wstring key_path,
- std::wstring value_name, DWORD value_data,
+ SetRegValueWorkItem(HKEY predefined_root, const std::wstring& key_path,
+ const std::wstring& value_name, DWORD value_data,
bool overwrite);
// Root key of the target key under which the value is set. The root key can
« no previous file with comments | « chrome/installer/util/lzma_util.cc ('k') | chrome/installer/util/set_reg_value_work_item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698