Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3907)

Unified Diff: chrome/installer/util/version.h

Issue 151101: Fixit: Remove bunch of coverity warnings from chrome/installer/*. (Closed)
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/set_reg_value_work_item.cc ('k') | chrome/installer/util/version.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/version.h
diff --git a/chrome/installer/util/version.h b/chrome/installer/util/version.h
index 5d7e3c06ed4285b81ca387be259d982f433da91e..8bbabce47e8177e9292a1b0f57218c4a793f820a 100644
--- a/chrome/installer/util/version.h
+++ b/chrome/installer/util/version.h
@@ -1,9 +1,9 @@
-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_INSTALLER_UTIL_VERSION_H__
-#define CHROME_INSTALLER_UTIL_VERSION_H__
+#ifndef CHROME_INSTALLER_UTIL_VERSION_H_
+#define CHROME_INSTALLER_UTIL_VERSION_H_
#include <string>
@@ -27,7 +27,7 @@ public:
// Assume that the version string is specified by four integers separated
// by character '.'. Return NULL if string is not of this format.
// Caller is responsible for freeing the Version object once done.
- static Version* GetVersionFromString(std::wstring version_str);
+ static Version* GetVersionFromString(const std::wstring& version_str);
private:
int64 major_;
« no previous file with comments | « chrome/installer/util/set_reg_value_work_item.cc ('k') | chrome/installer/util/version.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698