Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: chrome/installer/util/delete_tree_work_item.h

Issue 151101: Fixit: Remove bunch of coverity warnings from chrome/installer/*. (Closed)
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/delete_reg_value_work_item.cc ('k') | chrome/installer/util/delete_tree_work_item.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/delete_tree_work_item.h
diff --git a/chrome/installer/util/delete_tree_work_item.h b/chrome/installer/util/delete_tree_work_item.h
index 571d2d0a065f630c3aa4827744842405a227ff13..cf7b4be2147a0647493d496e89314870b4572eb4 100644
--- a/chrome/installer/util/delete_tree_work_item.h
+++ b/chrome/installer/util/delete_tree_work_item.h
@@ -1,9 +1,9 @@
-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_INSTALLER_UTIL_DELETE_TREE_WORK_ITEM_H__
-#define CHROME_INSTALLER_UTIL_DELETE_TREE_WORK_ITEM_H__
+#ifndef CHROME_INSTALLER_UTIL_DELETE_TREE_WORK_ITEM_H_
+#define CHROME_INSTALLER_UTIL_DELETE_TREE_WORK_ITEM_H_
#include <string>
#include <windows.h>
@@ -26,9 +26,10 @@ class DeleteTreeWorkItem : public WorkItem {
friend class WorkItem;
// Get a backup path that can keep root_path_ or key_path_
- bool GetBackupPath(std::wstring for_path, std::wstring* backup_path);
+ bool GetBackupPath(const std::wstring& for_path, std::wstring* backup_path);
- DeleteTreeWorkItem(std::wstring root_path, std::wstring key_path);
+ DeleteTreeWorkItem(const std::wstring& root_path,
+ const std::wstring& key_path);
// Root path to delete.
std::wstring root_path_;
@@ -46,4 +47,4 @@ class DeleteTreeWorkItem : public WorkItem {
std::wstring key_backup_path_;
};
-#endif // CHROME_INSTALLER_UTIL_DELETE_TREE_WORK_ITEM_H__
+#endif // CHROME_INSTALLER_UTIL_DELETE_TREE_WORK_ITEM_H_
« no previous file with comments | « chrome/installer/util/delete_reg_value_work_item.cc ('k') | chrome/installer/util/delete_tree_work_item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698