Fixit: Remove bunch of coverity warnings from chrome/installer/*.

chrome/installer/util/work_item_list.h

-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_INSTALLER_UTIL_WORK_ITEM_LIST_H__
-#define CHROME_INSTALLER_UTIL_WORK_ITEM_LIST_H__
+#ifndef CHROME_INSTALLER_UTIL_WORK_ITEM_LIST_H_
+#define CHROME_INSTALLER_UTIL_WORK_ITEM_LIST_H_
 
 #include <windows.h>
 
 #include <list>
 #include <string>
 
 #include "chrome/installer/util/work_item.h"
 
 // A WorkItem subclass that recursively contains a list of WorkItems. Thus it
 // provides functionalities to carry out or roll back the sequence of actions
@@ skipping 10 matching lines @@
   // Rollback the WorkItems in the reverse order as they are executed.
   virtual void Rollback();
 
   // Add a WorkItem to the list. Return true if the WorkItem is successfully
   // added. Return false otherwise.
   // A WorkItem can only be added to the list before the list's DO() is called.
   // Once a WorkItem is added to the list. The list owns the WorkItem.
   bool AddWorkItem(WorkItem* work_item);
 
   // Add a CopyTreeWorkItem to the list of work items.
-  bool AddCopyTreeWorkItem(std::wstring source_path, std::wstring dest_path,
-                           std::wstring temp_dir,
+  bool AddCopyTreeWorkItem(const std::wstring& source_path,
+                           const std::wstring& dest_path,
+                           const std::wstring& temp_dir,
                            CopyOverWriteOption overwrite_option,
-                           std::wstring alternative_path = L"");
+                           const std::wstring& alternative_path = L"");
 
   // Add a CreateDirWorkItem that creates a directory at the given path.
-  bool AddCreateDirWorkItem(std::wstring path);
+  bool AddCreateDirWorkItem(const std::wstring& path);
 
   // Add a CreateRegKeyWorkItem that creates a registry key at the given
   // path.
-  bool AddCreateRegKeyWorkItem(HKEY predefined_root, std::wstring path);
+  bool AddCreateRegKeyWorkItem(HKEY predefined_root, const std::wstring& path);
 
   // Add a DeleteRegValueWorkItem that deletes registry value of type REG_SZ
   // or REG_DWORD.
-  bool AddDeleteRegValueWorkItem(HKEY predefined_root, std::wstring key_path,
-                                 std::wstring value_name, bool is_str_type);
+  bool AddDeleteRegValueWorkItem(HKEY predefined_root,
+                                 const std::wstring& key_path,
+                                 const std::wstring& value_name,
+                                 bool is_str_type);
 
   // Add a DeleteTreeWorkItem that recursively deletes a file system
   // hierarchy at the given root path. A key file can be optionally specified
   // by key_path.
-  bool AddDeleteTreeWorkItem(std::wstring root_path, std::wstring key_path);
+  bool AddDeleteTreeWorkItem(const std::wstring& root_path,
+                             const std::wstring& key_path);
 
   // Add a MoveTreeWorkItem to the list of work items.
-  bool AddMoveTreeWorkItem(std::wstring source_path, std::wstring dest_path,
-                           std::wstring temp_dir);
+  bool AddMoveTreeWorkItem(const std::wstring& source_path,
+                           const std::wstring& dest_path,
+                           const std::wstring& temp_dir);
 
   // Add a SetRegValueWorkItem that sets a registry value with REG_SZ type
   // at the key with specified path.
-  bool AddSetRegValueWorkItem(HKEY predefined_root, std::wstring key_path,
-                              std::wstring value_name, std::wstring value_data,
+  bool AddSetRegValueWorkItem(HKEY predefined_root,
+                              const std::wstring& key_path,
+                              const std::wstring& value_name,
+                              const std::wstring& value_data,
                               bool overwrite);
 
   // Add a SetRegValueWorkItem that sets a registry value with REG_DWORD type
   // at the key with specified path.
-  bool AddSetRegValueWorkItem(HKEY predefined_root, std::wstring key_path,
-                              std::wstring value_name, DWORD value_data,
+  bool AddSetRegValueWorkItem(HKEY predefined_root,
+                              const std::wstring& key_path,
+                              const std::wstring& value_name,
+                              DWORD value_data,
                               bool overwrite);
 
   // Add a SelfRegWorkItem that registers or unregisters a DLL at the
   // specified path.
   bool AddSelfRegWorkItem(const std::wstring& dll_path, bool do_register);
 
  private:
   friend class WorkItem;
 
   typedef std::list<WorkItem*> WorkItems;
@@ skipping 13 matching lines @@
   ListStatus status_;
 
   // The list of WorkItems, in the order of them being added.
   WorkItems list_;
 
   // The list of executed WorkItems, in the reverse order of them being
   // executed.
   WorkItems executed_list_;
 };
 
-#endif  // CHROME_INSTALLER_UTIL_WORK_ITEM_LIST_H__
+#endif  // CHROME_INSTALLER_UTIL_WORK_ITEM_LIST_H_