Fixit: Remove bunch of coverity warnings from chrome/installer/*.

chrome/installer/gcapi/gcapi.cc

-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/gcapi/gcapi.h"
 
 #include <atlbase.h>
 #include <atlcom.h>
 #include <windows.h>
 #include <sddl.h>
 #include <stdlib.h>
@@ skipping 295 matching lines @@
   }
 
   // Then only check whether we can re-offer, if everything else is OK.
   if (local_reasons == 0 && !CanReOfferChrome(set_flag))
     local_reasons |= GCCC_ERROR_ALREADYOFFERED;
 
   // Done. Copy/return results.
   if (reasons != NULL)
     *reasons = local_reasons;
 
-  return (*reasons == 0);
+  return (local_reasons == 0);
 }
 
 #pragma comment(linker, "/EXPORT:LaunchGoogleChrome=_LaunchGoogleChrome@0,PRIVATE")
 DLLEXPORT BOOL __stdcall LaunchGoogleChrome() {
   wchar_t launch_cmd[MAX_PATH];
   size_t size = _countof(launch_cmd);
   if (!ReadValueFromRegistry(HKEY_LOCAL_MACHINE, kChromeRegClientStateKey,
                              kChromeRegLastLaunchCmd, launch_cmd, &size)) {
     size = _countof(launch_cmd);
     if (!ReadValueFromRegistry(HKEY_LOCAL_MACHINE, kChromeRegClientStateKey,
@@ skipping 112 matching lines @@
   // This loop iterates through all of the top-level Windows named
   // Chrome_WidgetWin_0, and looks for the first one with any children.
   while (handle && !FindWindowEx(handle, NULL, L"Chrome_WidgetWin_0", NULL)) {
     // Get the next top-level Chrome window.
     handle = FindWindowEx(NULL, handle, L"Chrome_WidgetWin_0", NULL);
   }
 
   return (handle &&
           SetWindowPos(handle, 0, x, y, width, height, SWP_NOZORDER));
 }