Subzero: switch from llvm-objdump to objdump for lit tests (for LLVM merge)

Subzero: switch from llvm-objdump to objdump for lit tests (for LLVM merge)

After the next LLVM merge, llvm-objdump is going to lose the "--symbolize"
flag. It also sounds like llvm-objdump may at some point converge to the
objdump-style of output.

So, rather than keep updating test expectations, switch to objdump,
assuming objdump will be more stable than llvm-objdump.

Also stash the assembler/disassembler commandlines in
the run-llvm2ice.py script. In theory this will let us
tweak the commandlines more easily (one place).
In practice the test expectatations will probably need
to be adjusted if the base commandlines change though.

Bulk edit the test expectations to match objdump now.
Some of this is assisted by a python script.
Example script: https://codereview.chromium.org/928663002/

BUG= https://code.google.com/p/nativeclient/issues/detail?id=4026
R=kschimpf@google.com, stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=a2703ae428a7c72b7716258b8ee157064d03c5cb

[jvoung (off chromium), 2015-02-13 23:35:18]

jvoung@chromium.org changed reviewers:
+ kschimpf@google.com, stichnot@chromium.org

[jvoung (off chromium), 2015-02-13 23:37:23]

This is not really ready at all, but roughly what the changes look like.

https://codereview.chromium.org/914263005/diff/1/tests_lit/llvm2ice_tests/nac...
File tests_lit/llvm2ice_tests/nacl-atomic-cmpxchg-optimization.ll (right):

https://codereview.chromium.org/914263005/diff/1/tests_lit/llvm2ice_tests/nac...
tests_lit/llvm2ice_tests/nacl-atomic-cmpxchg-optimization.ll:3: ; RUN: %p2i -i
%s --assemble --disassemble --args -O2 --verbose none \
Maybe this should pass the architecture flag to the assemble / disassemble too
while we are at it...

https://codereview.chromium.org/914263005/diff/1/tests_lit/llvm2ice_tests/vec...
File tests_lit/llvm2ice_tests/vector-arith.ll (right):

https://codereview.chromium.org/914263005/diff/1/tests_lit/llvm2ice_tests/vec...
tests_lit/llvm2ice_tests/vector-arith.ll:10: ; RUN:   \
Hmm...

[Karl, 2015-02-16 18:50:13]

https://codereview.chromium.org/914263005/diff/40001/Makefile.standalone
File Makefile.standalone (right):

https://codereview.chromium.org/914263005/diff/40001/Makefile.standalone#newc...
Makefile.standalone:33: ../../out/binutils_pnacl_x86_64_linux_install/bin)
Why is this different than other lines suchas LLVM_PATH (i.e. uses
...linux_work/Release+Asserts/bin versus ....linux_install/bin). Shouldn't we
consistently be using one or the other (i.e. work or install directories)?

[jvoung (off chromium), 2015-02-17 22:17:04]

Okay tests pass again, PTAL thanks!

https://codereview.chromium.org/914263005/diff/40001/Makefile.standalone
File Makefile.standalone (right):

https://codereview.chromium.org/914263005/diff/40001/Makefile.standalone#newc...
Makefile.standalone:33: ../../out/binutils_pnacl_x86_64_linux_install/bin)
On 2015/02/16 18:50:13, Karl wrote:
> Why is this different than other lines suchas LLVM_PATH (i.e. uses
> ...linux_work/Release+Asserts/bin versus ....linux_install/bin). Shouldn't we
> consistently be using one or the other (i.e. work or install directories)?

Okay making it the work directory too (I originally had trouble finding where
the binary was, then used "find").

[Karl, 2015-02-19 16:34:26]

lgtm

[Jim Stichnoth, 2015-02-19 18:58:10]

Also lgtm - and bonus points if you feel like converting to AT&T syntax. :)

[jvoung (off chromium), 2015-02-19 19:23:10]

On 2015/02/19 18:58:10, stichnot wrote:
> Also lgtm - and bonus points if you feel like converting to AT&T syntax. :)

Queue Michael Scott meme.

[jvoung (off chromium), 2015-02-19 19:23:42]

On 2015/02/19 19:23:10, jvoung wrote:
> On 2015/02/19 18:58:10, stichnot wrote:
> > Also lgtm - and bonus points if you feel like converting to AT&T syntax. :)
> 
> Queue Michael Scott meme.

or cue?

[jvoung (off chromium), 2015-02-19 19:27:54]

Committed patchset #8 (id:140001) manually as
a2703ae428a7c72b7716258b8ee157064d03c5cb (tree was closed).

[Jim Stichnoth, 2015-02-19 19:29:20]

On 2015/02/19 19:23:42, jvoung wrote:
> On 2015/02/19 19:23:10, jvoung wrote:
> > On 2015/02/19 18:58:10, stichnot wrote:
> > > Also lgtm - and bonus points if you feel like converting to AT&T syntax.
:)
> > 
> > Queue Michael Scott meme.
> 
> or cue?

Some employees like to convert to AT&T syntax, and we encourage that.