Rename GrOptDrawState to GrPipeline and GrDrawState to GrPipelineBuilder

Rename GrOptDrawState to GrPipeline and GrDrawState to GrPipelineBuilder

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/8dd688b7569df569a672a8a67b2db86a9d376cfc

[egdaniel, 2015-01-22 15:32:55]

egdaniel@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com

[egdaniel, 2015-01-22 15:32:56]

ptal

[joshualitt, 2015-01-22 15:55:09]

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrDrawTarget.h
File src/gpu/GrDrawTarget.h (right):

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrDrawTarget.h#n...
src/gpu/GrDrawTarget.h:265: * on the pipeline builder (if possible in the 3D
API).  Note, we will never have an inverse
GrPipelineBuilder

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrDrawTarget.h#n...
src/gpu/GrDrawTarget.h:375: * Clear the passed in render target. Ignores the
pipeline builder and clip. Clears the whole
GrPipelineBuilder

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPathRenderer.h
File src/gpu/GrPathRenderer.h (right):

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPathRenderer.h...
src/gpu/GrPathRenderer.h:27: *  Derived classes can use stages
GrPaint::kTotalStages through GrPipelineBuilder::kNumStages-1. The
line wrap

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipeline.cpp
File src/gpu/GrPipeline.cpp (right):

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipeline.cpp#n...
src/gpu/GrPipeline.cpp:44: // When path rendering the stencil settings are not
always set on the pipeline builder
GrPipelineBuilder

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipeline.cpp#n...
src/gpu/GrPipeline.cpp:76: // pipelineBuilder's coverageProcInfo (like color
above) to set this initial information.
Gr

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipeline.h
File src/gpu/GrPipeline.h (right):

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipeline.h#new...
src/gpu/GrPipeline.h:25: * Class that holds an optimized version of a
GrPipelineBuilder. It is meant to be an immutable class,
Line wrap

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipelineBuilde...
File src/gpu/GrPipelineBuilder.cpp (right):

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipelineBuilde...
src/gpu/GrPipelineBuilder.cpp:60: >>>>>>> Rename GrOptDrawState to GrPipeline
and GrDrawState to GrPipelineBuilder:src/gpu/GrPipelineBuilder.cpp
Delete

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipelineBuilder.h
File src/gpu/GrPipelineBuilder.h (right):

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipelineBuilde...
src/gpu/GrPipelineBuilder.h:47: * GrPipelineBuilder encompasses more than
GrPaint. Aspects of GrPipelineBuilder that have no GrPaint
\n

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipelineBuilde...
src/gpu/GrPipelineBuilder.h:60: * This function considers the current pipeline
builder and the draw target's capabilities to
Gr

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipelineBuilde...
src/gpu/GrPipelineBuilder.h:175: * When this object is destroyed it will remove
any color/coverage effects from the pipeline
Gr

https://codereview.chromium.org/858343002/diff/40001/tests/GLProgramsTest.cpp
File tests/GLProgramsTest.cpp (right):

https://codereview.chromium.org/858343002/diff/40001/tests/GLProgramsTest.cpp...
tests/GLProgramsTest.cpp:124: static void set_random_xpf(GrContext* context,
const GrDrawTargetCaps& caps, GrPipelineBuilder* pipelineBuilder,
\n

[bsalomon, 2015-01-22 16:02:44]

review backlog, I defer to Joshua.

[bsalomon, 2015-01-22 16:04:36]

Metacomment - Maybe we should start using actual class names in comments
whenever possible to make this kind of search and replace easier (e.g.
GrPipeline, GrDrawTarget, instead of pipeline or target).

[egdaniel, 2015-01-22 16:28:57]

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrDrawTarget.h
File src/gpu/GrDrawTarget.h (right):

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrDrawTarget.h#n...
src/gpu/GrDrawTarget.h:265: * on the pipeline builder (if possible in the 3D
API).  Note, we will never have an inverse
On 2015/01/22 15:55:07, joshualitt wrote:
> GrPipelineBuilder

Done.

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrDrawTarget.h#n...
src/gpu/GrDrawTarget.h:375: * Clear the passed in render target. Ignores the
pipeline builder and clip. Clears the whole
On 2015/01/22 15:55:07, joshualitt wrote:
> GrPipelineBuilder

Done.

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPathRenderer.h
File src/gpu/GrPathRenderer.h (right):

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPathRenderer.h...
src/gpu/GrPathRenderer.h:27: *  Derived classes can use stages
GrPaint::kTotalStages through GrPipelineBuilder::kNumStages-1. The
On 2015/01/22 15:55:07, joshualitt wrote:
> line wrap

Done.

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipeline.cpp
File src/gpu/GrPipeline.cpp (right):

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipeline.cpp#n...
src/gpu/GrPipeline.cpp:44: // When path rendering the stencil settings are not
always set on the pipeline builder
On 2015/01/22 15:55:08, joshualitt wrote:
> GrPipelineBuilder

Done.

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipeline.cpp#n...
src/gpu/GrPipeline.cpp:76: // pipelineBuilder's coverageProcInfo (like color
above) to set this initial information.
On 2015/01/22 15:55:08, joshualitt wrote:
> Gr

Done.

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipeline.h
File src/gpu/GrPipeline.h (right):

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipeline.h#new...
src/gpu/GrPipeline.h:25: * Class that holds an optimized version of a
GrPipelineBuilder. It is meant to be an immutable class,
On 2015/01/22 15:55:08, joshualitt wrote:
> Line wrap

Done.

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipelineBuilde...
File src/gpu/GrPipelineBuilder.cpp (right):

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipelineBuilde...
src/gpu/GrPipelineBuilder.cpp:60: >>>>>>> Rename GrOptDrawState to GrPipeline
and GrDrawState to GrPipelineBuilder:src/gpu/GrPipelineBuilder.cpp
On 2015/01/22 15:55:08, joshualitt wrote:
> Delete

Done.

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipelineBuilder.h
File src/gpu/GrPipelineBuilder.h (right):

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipelineBuilde...
src/gpu/GrPipelineBuilder.h:47: * GrPipelineBuilder encompasses more than
GrPaint. Aspects of GrPipelineBuilder that have no GrPaint
On 2015/01/22 15:55:08, joshualitt wrote:
> \n

Done.

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipelineBuilde...
src/gpu/GrPipelineBuilder.h:60: * This function considers the current pipeline
builder and the draw target's capabilities to
On 2015/01/22 15:55:08, joshualitt wrote:
> Gr

Done.

https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipelineBuilde...
src/gpu/GrPipelineBuilder.h:175: * When this object is destroyed it will remove
any color/coverage effects from the pipeline
On 2015/01/22 15:55:08, joshualitt wrote:
> Gr

Done.

https://codereview.chromium.org/858343002/diff/40001/tests/GLProgramsTest.cpp
File tests/GLProgramsTest.cpp (right):

https://codereview.chromium.org/858343002/diff/40001/tests/GLProgramsTest.cpp...
tests/GLProgramsTest.cpp:124: static void set_random_xpf(GrContext* context,
const GrDrawTargetCaps& caps, GrPipelineBuilder* pipelineBuilder,
On 2015/01/22 15:55:08, joshualitt wrote:
> \n

Done.

[joshualitt, 2015-01-22 16:46:48]

On 2015/01/22 16:28:57, egdaniel wrote:
> https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrDrawTarget.h
> File src/gpu/GrDrawTarget.h (right):
> 
>
https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrDrawTarget.h#n...
> src/gpu/GrDrawTarget.h:265: * on the pipeline builder (if possible in the 3D
> API).  Note, we will never have an inverse
> On 2015/01/22 15:55:07, joshualitt wrote:
> > GrPipelineBuilder
> 
> Done.
> 
>
https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrDrawTarget.h#n...
> src/gpu/GrDrawTarget.h:375: * Clear the passed in render target. Ignores the
> pipeline builder and clip. Clears the whole
> On 2015/01/22 15:55:07, joshualitt wrote:
> > GrPipelineBuilder
> 
> Done.
> 
> https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPathRenderer.h
> File src/gpu/GrPathRenderer.h (right):
> 
>
https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPathRenderer.h...
> src/gpu/GrPathRenderer.h:27: *  Derived classes can use stages
> GrPaint::kTotalStages through GrPipelineBuilder::kNumStages-1. The
> On 2015/01/22 15:55:07, joshualitt wrote:
> > line wrap
> 
> Done.
> 
> https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipeline.cpp
> File src/gpu/GrPipeline.cpp (right):
> 
>
https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipeline.cpp#n...
> src/gpu/GrPipeline.cpp:44: // When path rendering the stencil settings are not
> always set on the pipeline builder
> On 2015/01/22 15:55:08, joshualitt wrote:
> > GrPipelineBuilder
> 
> Done.
> 
>
https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipeline.cpp#n...
> src/gpu/GrPipeline.cpp:76: // pipelineBuilder's coverageProcInfo (like color
> above) to set this initial information.
> On 2015/01/22 15:55:08, joshualitt wrote:
> > Gr
> 
> Done.
> 
> https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipeline.h
> File src/gpu/GrPipeline.h (right):
> 
>
https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipeline.h#new...
> src/gpu/GrPipeline.h:25: * Class that holds an optimized version of a
> GrPipelineBuilder. It is meant to be an immutable class,
> On 2015/01/22 15:55:08, joshualitt wrote:
> > Line wrap
> 
> Done.
> 
>
https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipelineBuilde...
> File src/gpu/GrPipelineBuilder.cpp (right):
> 
>
https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipelineBuilde...
> src/gpu/GrPipelineBuilder.cpp:60: >>>>>>> Rename GrOptDrawState to GrPipeline
> and GrDrawState to GrPipelineBuilder:src/gpu/GrPipelineBuilder.cpp
> On 2015/01/22 15:55:08, joshualitt wrote:
> > Delete
> 
> Done.
> 
>
https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipelineBuilder.h
> File src/gpu/GrPipelineBuilder.h (right):
> 
>
https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipelineBuilde...
> src/gpu/GrPipelineBuilder.h:47: * GrPipelineBuilder encompasses more than
> GrPaint. Aspects of GrPipelineBuilder that have no GrPaint
> On 2015/01/22 15:55:08, joshualitt wrote:
> > \n
> 
> Done.
> 
>
https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipelineBuilde...
> src/gpu/GrPipelineBuilder.h:60: * This function considers the current pipeline
> builder and the draw target's capabilities to
> On 2015/01/22 15:55:08, joshualitt wrote:
> > Gr
> 
> Done.
> 
>
https://codereview.chromium.org/858343002/diff/40001/src/gpu/GrPipelineBuilde...
> src/gpu/GrPipelineBuilder.h:175: * When this object is destroyed it will
remove
> any color/coverage effects from the pipeline
> On 2015/01/22 15:55:08, joshualitt wrote:
> > Gr
> 
> Done.
> 
> https://codereview.chromium.org/858343002/diff/40001/tests/GLProgramsTest.cpp
> File tests/GLProgramsTest.cpp (right):
> 
>
https://codereview.chromium.org/858343002/diff/40001/tests/GLProgramsTest.cpp...
> tests/GLProgramsTest.cpp:124: static void set_random_xpf(GrContext* context,
> const GrDrawTargetCaps& caps, GrPipelineBuilder* pipelineBuilder,
> On 2015/01/22 15:55:08, joshualitt wrote:
> > \n
> 
> Done.

lgtm

[egdaniel, 2015-01-22 16:49:11]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2015-01-22 16:50:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/858343002/80001

[commit-bot: I haz the power, 2015-01-22 16:50:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-22 16:50:32]

Presubmit check for 858343002-80001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')

Was the presubmit check useful? If not, run "git cl presubmit -v"
to figure out which PRESUBMIT.py was run, then run git blame
on the file to figure out who to ask for help.

[bsalomon, 2015-01-22 17:01:40]

On 2015/01/22 16:50:32, I haz the power (commit-bot) wrote:
> Presubmit check for 858343002-80001 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit ERRORS **
> Since the CL is editing public API, you must have an LGTM from one of:
> (mailto:, mailto:, mailto:,
> mailto:, mailto:, mailto:)
> 
> Was the presubmit check useful? If not, run "git cl presubmit -v"
> to figure out which PRESUBMIT.py was run, then run git blame
> on the file to figure out who to ask for help.

lgtm

[egdaniel, 2015-01-22 18:07:29]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2015-01-22 18:08:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/858343002/80001

[commit-bot: I haz the power, 2015-01-22 18:16:14]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/8dd688b7569df569a672a8a67b2db86a9d376cfc