|
json_schema_compiler: Use std::vector<char> for binary values.
This change enables ArrayBuffer[] in IDLs / json-schema descriptions of extension APIs.
This affects the code generated from these descriptions:
The C++ members (and arguments to the ::Create functions) that refer to binary values are now represented by std::vector<char> instead of std::string.
All usages are adapted in this CL.
While there, this change updates the affected code parts
- to use vector_as_array where it makes sense
- unnecessary copies are removed where easily possible
- and range based assigns ( ::assign(InputIterator first, InputIterator last) or the same with c'tors) are uniformly used.
BUG= 448383
TBR=stevenjb@chromium.org (chromeos/dbus was reviewed by bartfab@)
Committed: https://crrev.com/93871258123f9c02d00dc33ff96d1d4a240fae68
Cr-Commit-Position: refs/heads/master@{#312183}
Total comments: 13
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+289 lines, -168 lines) |
Patch |
|
M |
base/values.h
|
View
|
|
3 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
base/values.cc
|
View
|
|
2 chunks |
+10 lines, -0 lines |
0 comments
|
Download
|
|
M |
base/values_unittest.cc
|
View
|
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/extensions/wallpaper_api.cc
|
View
|
1
|
2 chunks |
+5 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/extensions/wallpaper_function_base.h
|
View
|
1
|
2 chunks |
+4 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/extensions/wallpaper_function_base.cc
|
View
|
1
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/extensions/wallpaper_private_api.h
|
View
|
1
|
2 chunks |
+4 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/extensions/wallpaper_private_api.cc
|
View
|
1
|
6 chunks |
+14 lines, -7 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/file_system_provider/operations/read_file.cc
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/file_system_provider/operations/write_file_unittest.cc
|
View
|
1
2
3
4
5
|
2 chunks |
+5 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/copresence/chrome_whispernet_client.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/braille_display_private/braille_controller.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.h
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc
|
View
|
|
3 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/braille_display_private/braille_controller_stub.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/braille_display_private/stub_braille_controller.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/braille_display_private/stub_braille_controller.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/copresence/copresence_api.cc
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/copresence/copresence_api_unittest.cc
|
View
|
1
2
3
4
5
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/copresence/copresence_translations.cc
|
View
|
|
3 chunks |
+6 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/copresence_private/copresence_private_api.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
|
View
|
1
2
|
8 chunks |
+19 lines, -13 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_crypto_delegate_chromeos.cc
|
View
|
1
|
2 chunks |
+32 lines, -16 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc
|
View
|
|
6 chunks |
+16 lines, -12 lines |
0 comments
|
Download
|
|
M |
chrome/browser/image_decoder.h
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/image_decoder.cc
|
View
|
|
1 chunk |
+10 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/notifications/notification_conversion_helper.cc
|
View
|
|
3 chunks |
+12 lines, -8 lines |
0 comments
|
Download
|
|
M |
chromeos/dbus/fake_shill_third_party_vpn_driver_client.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chromeos/dbus/fake_shill_third_party_vpn_driver_client.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chromeos/dbus/shill_third_party_vpn_driver_client.h
|
View
|
|
3 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
chromeos/dbus/shill_third_party_vpn_driver_client.cc
|
View
|
1
2
3
|
4 chunks |
+9 lines, -7 lines |
0 comments
|
Download
|
|
M |
chromeos/dbus/shill_third_party_vpn_driver_client_unittest.cc
|
View
|
1
|
5 chunks |
+9 lines, -6 lines |
0 comments
|
Download
|
|
M |
chromeos/dbus/shill_third_party_vpn_observer.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/browser/speech/google_streaming_remote_engine_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/public/browser/speech_recognition_session_preamble.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
extensions/browser/api/bluetooth_socket/bluetooth_socket_event_dispatcher.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
extensions/browser/api/copresence_endpoints/copresence_endpoints_api.cc
|
View
|
|
2 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
extensions/browser/api/hid/hid_api.cc
|
View
|
|
3 chunks |
+5 lines, -4 lines |
0 comments
|
Download
|
|
M |
extensions/browser/api/hid/hid_device_manager.cc
|
View
|
1
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
extensions/browser/api/serial/serial_connection.h
|
View
|
|
3 chunks |
+5 lines, -3 lines |
0 comments
|
Download
|
|
M |
extensions/browser/api/serial/serial_connection.cc
|
View
|
|
5 chunks |
+8 lines, -5 lines |
0 comments
|
Download
|
|
M |
extensions/browser/api/serial/serial_event_dispatcher.h
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
extensions/browser/api/serial/serial_event_dispatcher.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
extensions/browser/api/sockets_tcp/tcp_socket_event_dispatcher.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
extensions/browser/api/sockets_tcp/tcp_socket_event_dispatcher.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
extensions/browser/api/sockets_udp/udp_socket_event_dispatcher.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
extensions/browser/api/sockets_udp/udp_socket_event_dispatcher.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
extensions/browser/api/usb/usb_api.cc
|
View
|
1
|
3 chunks |
+3 lines, -15 lines |
0 comments
|
Download
|
|
M |
extensions/browser/api/vpn_provider/vpn_service.h
|
View
|
|
3 chunks |
+5 lines, -4 lines |
0 comments
|
Download
|
|
M |
extensions/browser/api/vpn_provider/vpn_service.cc
|
View
|
|
3 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
tools/json_schema_compiler/cc_generator.py
|
View
|
1
2
3
4
|
4 chunks |
+12 lines, -8 lines |
0 comments
|
Download
|
|
M |
tools/json_schema_compiler/cpp_type_generator.py
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
tools/json_schema_compiler/util.h
|
View
|
1
|
3 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
tools/json_schema_compiler/util.cc
|
View
|
1
2
3
4
5
6
|
5 chunks |
+17 lines, -3 lines |
0 comments
|
Download
|
Total messages: 26 (9 generated)
|