extensions/browser/api/serial/serial_event_dispatcher.h - Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/serial/serial_event_dispatcher.h

Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify_json_schema

Patch Set: Fix merge error. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/serial/serial_connection.cc ('k') | extensions/browser/api/serial/serial_event_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/serial/serial_event_dispatcher.h

diff --git a/extensions/browser/api/serial/serial_event_dispatcher.h b/extensions/browser/api/serial/serial_event_dispatcher.h

index 288bc625ca869c2957f83ddbbe9492fab7c53984..408fc68c169d7acc6c528b4c3e54b32af68642bd 100644

--- a/extensions/browser/api/serial/serial_event_dispatcher.h

+++ b/extensions/browser/api/serial/serial_event_dispatcher.h

@@ -6,6 +6,7 @@

#define EXTENSIONS_BROWSER_API_SERIAL_SERIAL_EVENT_DISPATCHER_H_

#include <string>

+#include <vector>

#include "extensions/browser/api/api_resource_manager.h"

#include "extensions/common/api/serial.h"

@@ -59,7 +60,7 @@ class SerialEventDispatcher : public BrowserContextKeyedAPI {

static void StartReceive(const ReceiveParams& params);

static void ReceiveCallback(const ReceiveParams& params,

- const std::string& data,

+ const std::vector<char>& data,

serial::ReceiveError error);

static void PostEvent(const ReceiveParams& params,

« no previous file with comments | « extensions/browser/api/serial/serial_connection.cc ('k') | extensions/browser/api/serial/serial_event_dispatcher.cc » ('j') | no next file with comments »