tools/json_schema_compiler/cpp_type_generator.py - Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/cpp_type_generator.py

Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify_json_schema

Patch Set: Fix merge error. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/json_schema_compiler/cpp_type_generator.py

diff --git a/tools/json_schema_compiler/cpp_type_generator.py b/tools/json_schema_compiler/cpp_type_generator.py

index 44ff97898f24e53b19babac6d343dac21e208634..5a573b65a269f16f3cd05995fe2583028ef6a338 100644

--- a/tools/json_schema_compiler/cpp_type_generator.py

+++ b/tools/json_schema_compiler/cpp_type_generator.py

@@ -112,7 +112,7 @@ class CppTypeGenerator(object):

item_cpp_type = self.GetCppType(type_.item_type, is_in_container=True)

cpp_type = 'std::vector<%s>' % cpp_util.PadForGenerics(item_cpp_type)

elif type_.property_type == PropertyType.BINARY:

- cpp_type = 'std::string'

+ cpp_type = 'std::vector<char>'

else:

raise NotImplementedError('Cannot get type of %s' % type_.property_type)

« no previous file with comments | « tools/json_schema_compiler/cc_generator.py ('k') | tools/json_schema_compiler/util.h » ('j') | no next file with comments »