Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: tools/json_schema_compiler/util.h

Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify_json_schema
Patch Set: Fix merge error. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/json_schema_compiler/cpp_type_generator.py ('k') | tools/json_schema_compiler/util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/json_schema_compiler/util.h
diff --git a/tools/json_schema_compiler/util.h b/tools/json_schema_compiler/util.h
index 15c86e7f8c4e9a458187e56fc18c20030e49e9be..c27e48adfc9762d15907c257ae2c2091d6b3d1d7 100644
--- a/tools/json_schema_compiler/util.h
+++ b/tools/json_schema_compiler/util.h
@@ -22,6 +22,7 @@ bool PopulateItem(const base::Value& from, int* out);
bool PopulateItem(const base::Value& from, bool* out);
bool PopulateItem(const base::Value& from, double* out);
bool PopulateItem(const base::Value& from, std::string* out);
+bool PopulateItem(const base::Value& from, std::vector<char>* out);
bool PopulateItem(const base::Value& from, linked_ptr<base::Value>* out);
bool PopulateItem(const base::Value& from,
linked_ptr<base::DictionaryValue>* out);
@@ -74,6 +75,7 @@ void AddItemToList(const int from, base::ListValue* out);
void AddItemToList(const bool from, base::ListValue* out);
void AddItemToList(const double from, base::ListValue* out);
void AddItemToList(const std::string& from, base::ListValue* out);
+void AddItemToList(const std::vector<char>& from, base::ListValue* out);
void AddItemToList(const linked_ptr<base::Value>& from, base::ListValue* out);
void AddItemToList(const linked_ptr<base::DictionaryValue>& from,
base::ListValue* out);
@@ -122,4 +124,4 @@ std::string ValueTypeToString(base::Value::Type type);
} // namespace util
} // namespace json_schema_compiler
-#endif // TOOLS_JSON_SCHEMA_COMPILER_UTIL_H__
+#endif // TOOLS_JSON_SCHEMA_COMPILER_UTIL_H__
« no previous file with comments | « tools/json_schema_compiler/cpp_type_generator.py ('k') | tools/json_schema_compiler/util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698