extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc - Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc

Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify_json_schema

Patch Set: Fix merge error. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/browser/speech_recognition_session_preamble.h ('k') | extensions/browser/api/bluetooth_socket/bluetooth_socket_event_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc

diff --git a/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc b/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc

index 2ef959e2b9d8c3fc1d25f8f3889977c1fee01a37..727532c2948539bce104fb78816b664a6e43a187 100644

--- a/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc

+++ b/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc

@@ -105,7 +105,7 @@ void PopulateCharacteristic(const BluetoothGattCharacteristic* characteristic,

if (value.empty())

return;

- out->value.reset(new std::string(value.begin(), value.end()));

+ out->value.reset(new std::vector<char>(value.begin(), value.end()));

}

void PopulateDescriptor(const BluetoothGattDescriptor* descriptor,

@@ -122,7 +122,7 @@ void PopulateDescriptor(const BluetoothGattDescriptor* descriptor,

if (value.empty())

return;

- out->value.reset(new std::string(value.begin(), value.end()));

+ out->value.reset(new std::vector<char>(value.begin(), value.end()));

}

typedef extensions::ApiResourceManager<extensions::BluetoothLowEnergyConnection>