extensions/browser/api/bluetooth_socket/bluetooth_socket_event_dispatcher.cc - Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/bluetooth_socket/bluetooth_socket_event_dispatcher.cc

Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify_json_schema

Patch Set: Fix merge error. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc ('k') | extensions/browser/api/copresence_endpoints/copresence_endpoints_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/bluetooth_socket/bluetooth_socket_event_dispatcher.cc

diff --git a/extensions/browser/api/bluetooth_socket/bluetooth_socket_event_dispatcher.cc b/extensions/browser/api/bluetooth_socket/bluetooth_socket_event_dispatcher.cc

index 43528d8f9a126e370e629943d517e4f89f602c13..3daadf391d1dea8ff7b97e607763023091d07667 100644

--- a/extensions/browser/api/bluetooth_socket/bluetooth_socket_event_dispatcher.cc

+++ b/extensions/browser/api/bluetooth_socket/bluetooth_socket_event_dispatcher.cc

@@ -191,7 +191,7 @@ void BluetoothSocketEventDispatcher::ReceiveCallback(

// Dispatch "onReceive" event.

bluetooth_socket::ReceiveInfo receive_info;

receive_info.socket_id = params.socket_id;

- receive_info.data = std::string(io_buffer->data(), bytes_read);

+ receive_info.data.assign(io_buffer->data(), io_buffer->data() + bytes_read);

scoped_ptr<base::ListValue> args =

bluetooth_socket::OnReceive::Create(receive_info);

scoped_ptr<Event> event(