chrome/browser/extensions/api/braille_display_private/braille_controller_stub.cc - Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/braille_display_private/braille_controller_stub.cc

Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify_json_schema

Patch Set: Fix merge error. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc ('k') | chrome/browser/extensions/api/braille_display_private/stub_braille_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/braille_display_private/braille_controller_stub.cc

diff --git a/chrome/browser/extensions/api/braille_display_private/braille_controller_stub.cc b/chrome/browser/extensions/api/braille_display_private/braille_controller_stub.cc

index ba394d0472e737e55b5ce4ce503711b353b192ed..bd7b813633a2707c9104cca9ae9d446bb23db107 100644

--- a/chrome/browser/extensions/api/braille_display_private/braille_controller_stub.cc

+++ b/chrome/browser/extensions/api/braille_display_private/braille_controller_stub.cc

@@ -18,7 +18,7 @@ class BrailleControllerImpl : public BrailleController {

public:

static BrailleControllerImpl* GetInstance();

scoped_ptr<DisplayState> GetDisplayState() override;

- void WriteDots(const std::string& cells) override;

+ void WriteDots(const std::vector<char>& cells) override;

void AddObserver(BrailleObserver* observer) override;

void RemoveObserver(BrailleObserver* observer) override;

@@ -56,7 +56,7 @@ scoped_ptr<DisplayState> BrailleControllerImpl::GetDisplayState() {

return scoped_ptr<DisplayState>(new DisplayState()).Pass();

}

-void BrailleControllerImpl::WriteDots(const std::string& cells) {

+void BrailleControllerImpl::WriteDots(const std::vector<char>& cells) {

}

void BrailleControllerImpl::AddObserver(BrailleObserver* observer) {