chrome/browser/chromeos/file_system_provider/operations/write_file_unittest.cc - Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/write_file_unittest.cc

Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify_json_schema

Patch Set: Fix merge error. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_system_provider/operations/read_file.cc ('k') | chrome/browser/copresence/chrome_whispernet_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/operations/write_file_unittest.cc

diff --git a/chrome/browser/chromeos/file_system_provider/operations/write_file_unittest.cc b/chrome/browser/chromeos/file_system_provider/operations/write_file_unittest.cc

index 90e674761461774acf67359802829bc87f720d96..f1aac0af7fcb515465f184056ddb70e44f7c1a76 100644

--- a/chrome/browser/chromeos/file_system_provider/operations/write_file_unittest.cc

+++ b/chrome/browser/chromeos/file_system_provider/operations/write_file_unittest.cc

@@ -5,9 +5,11 @@

#include "chrome/browser/chromeos/file_system_provider/operations/write_file.h"

#include <string>

+#include <vector>

#include "base/files/file.h"

#include "base/files/file_path.h"

+#include "base/macros.h"

#include "base/memory/ref_counted.h"

#include "base/memory/scoped_ptr.h"

#include "base/memory/scoped_vector.h"

@@ -87,7 +89,9 @@ TEST_F(FileSystemProviderOperationsWriteFileTest, Execute) {

EXPECT_EQ(kRequestId, options.request_id);

EXPECT_EQ(kFileHandle, options.open_request_id);

EXPECT_EQ(kOffset, static_cast<double>(options.offset));

- EXPECT_EQ(std::string(kWriteData), options.data);

+ std::string write_data(kWriteData);

+ EXPECT_EQ(std::vector<char>(write_data.begin(), write_data.end()),

+ options.data);

}

TEST_F(FileSystemProviderOperationsWriteFileTest, Execute_NoListener) {