chrome/browser/extensions/api/braille_display_private/stub_braille_controller.cc - Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/braille_display_private/stub_braille_controller.cc

Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify_json_schema

Patch Set: Fix merge error. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/braille_display_private/stub_braille_controller.h ('k') | chrome/browser/extensions/api/copresence/copresence_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/braille_display_private/stub_braille_controller.cc

diff --git a/chrome/browser/extensions/api/braille_display_private/stub_braille_controller.cc b/chrome/browser/extensions/api/braille_display_private/stub_braille_controller.cc

index 8e9f312aa587b351b070a6abfe419797cad9fbef..d1e0da830a1ad170d4bc3a0c4eb7ce5449091ac0 100644

--- a/chrome/browser/extensions/api/braille_display_private/stub_braille_controller.cc

+++ b/chrome/browser/extensions/api/braille_display_private/stub_braille_controller.cc

@@ -15,7 +15,7 @@ scoped_ptr<DisplayState> StubBrailleController::GetDisplayState() {

return scoped_ptr<DisplayState>(new DisplayState);

}

-void StubBrailleController::WriteDots(const std::string& cells) {

+void StubBrailleController::WriteDots(const std::vector<char>& cells) {

}

void StubBrailleController::AddObserver(BrailleObserver* observer) {