Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3657)

Unified Diff: extensions/browser/api/vpn_provider/vpn_service.cc

Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify_json_schema
Patch Set: Fix merge error. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/vpn_provider/vpn_service.h ('k') | tools/json_schema_compiler/cc_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/vpn_provider/vpn_service.cc
diff --git a/extensions/browser/api/vpn_provider/vpn_service.cc b/extensions/browser/api/vpn_provider/vpn_service.cc
index b1f6199d881ad733694297ea1d0516bc2015cf9e..f2a7efb9faed535691074372eb15aca13b042851 100644
--- a/extensions/browser/api/vpn_provider/vpn_service.cc
+++ b/extensions/browser/api/vpn_provider/vpn_service.cc
@@ -71,7 +71,7 @@ class VpnService::VpnConfiguration : public ShillThirdPartyVpnObserver {
const std::string& object_path() const { return object_path_; }
// ShillThirdPartyVpnObserver:
- void OnPacketReceived(const std::string& data) override;
+ void OnPacketReceived(const std::vector<char>& data) override;
void OnPlatformMessage(uint32_t message) override;
private:
@@ -102,7 +102,8 @@ VpnService::VpnConfiguration::VpnConfiguration(
VpnService::VpnConfiguration::~VpnConfiguration() {
}
-void VpnService::VpnConfiguration::OnPacketReceived(const std::string& data) {
+void VpnService::VpnConfiguration::OnPacketReceived(
+ const std::vector<char>& data) {
if (!vpn_service_) {
return;
}
@@ -359,7 +360,7 @@ void VpnService::SetParameters(const std::string& extension_id,
}
void VpnService::SendPacket(const std::string& extension_id,
- const std::string& data,
+ const std::vector<char>& data,
const SuccessCallback& success,
const FailureCallback& failure) {
if (!DoesActiveConfigurationExistAndIsAccessAuthorized(extension_id)) {
« no previous file with comments | « extensions/browser/api/vpn_provider/vpn_service.h ('k') | tools/json_schema_compiler/cc_generator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698