chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.h - Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.h

Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify_json_schema

Patch Set: Fix merge error. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/braille_display_private/braille_controller.h ('k') | chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.h

diff --git a/chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.h b/chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.h

index 83af7e3127bf0582c2e67f1d2fe0b0819f1f7964..db3686759fca92cfca8779b8b7a7b8fabcb98e12 100644

--- a/chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.h

+++ b/chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.h

@@ -24,7 +24,7 @@ class BrailleControllerImpl : public BrailleController {

public:

static BrailleControllerImpl* GetInstance();

scoped_ptr<DisplayState> GetDisplayState() override;

- void WriteDots(const std::string& cells) override;

+ void WriteDots(const std::vector<char>& cells) override;

void AddObserver(BrailleObserver* observer) override;

void RemoveObserver(BrailleObserver* observer) override;