Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 772673002: Fix Animations, Remove Compostior Animations. (Closed)

Created:
6 years ago by rafaelw
Modified:
6 years ago
Reviewers:
esprehn, ojan
CC:
ojan, abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Fix Animations, Remove Compostior Animations. This patch (re)hooks up animations so they start and removes the infrastructure required by blink to synchronize the compositor and main threads. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8c0e929f2e547092bdb8040bcc68611dfc05fcae

Patch Set 1 #

Patch Set 2 : removed compositor animations (step 1) #

Patch Set 3 : more cleanup #

Patch Set 4 : cleanup #

Total comments: 1

Patch Set 5 : sync #

Patch Set 6 : resync #

Patch Set 7 : wee #

Patch Set 8 : for review #

Patch Set 9 : CompositorPendingAnimations -> PendingAnimations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -2546 lines) Patch
M sky/engine/core/animation/ActiveAnimations.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/animation/ActiveAnimations.cpp View 1 2 1 chunk +0 lines, -32 lines 0 comments Download
M sky/engine/core/animation/Animation.h View 1 2 chunks +0 lines, -10 lines 0 comments Download
M sky/engine/core/animation/Animation.cpp View 1 2 3 4 5 6 7 8 5 chunks +1 line, -69 lines 0 comments Download
M sky/engine/core/animation/AnimationPlayer.h View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -34 lines 0 comments Download
M sky/engine/core/animation/AnimationPlayer.cpp View 1 2 3 4 5 6 7 8 13 chunks +17 lines, -137 lines 0 comments Download
M sky/engine/core/animation/AnimationPlayerTest.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/animation/AnimationStack.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/animation/AnimationStack.cpp View 1 2 3 4 5 6 3 chunks +0 lines, -40 lines 0 comments Download
M sky/engine/core/animation/AnimationStackTest.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/animation/AnimationTimelineTest.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
D sky/engine/core/animation/CompositorAnimations.h View 1 1 chunk +0 lines, -85 lines 0 comments Download
D sky/engine/core/animation/CompositorAnimations.cpp View 1 1 chunk +0 lines, -499 lines 0 comments Download
D sky/engine/core/animation/CompositorAnimationsImpl.h View 1 1 chunk +0 lines, -61 lines 0 comments Download
D sky/engine/core/animation/CompositorAnimationsTest.cpp View 1 1 chunk +0 lines, -952 lines 0 comments Download
D sky/engine/core/animation/CompositorAnimationsTestHelper.h View 1 1 chunk +0 lines, -162 lines 0 comments Download
D sky/engine/core/animation/CompositorAnimationsTimingFunctionReverserTest.cpp View 1 1 chunk +0 lines, -85 lines 0 comments Download
M sky/engine/core/animation/CompositorPendingAnimations.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -70 lines 0 comments Download
M sky/engine/core/animation/CompositorPendingAnimations.cpp View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -135 lines 0 comments Download
M sky/engine/core/animation/DocumentAnimations.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/animation/DocumentAnimations.cpp View 1 2 3 4 5 6 7 8 2 chunks +1 line, -15 lines 0 comments Download
A + sky/engine/core/animation/PendingAnimations.h View 1 2 3 4 5 6 7 8 2 chunks +9 lines, -11 lines 0 comments Download
A + sky/engine/core/animation/PendingAnimations.cpp View 1 2 3 4 5 6 7 8 4 chunks +7 lines, -54 lines 0 comments Download
M sky/engine/core/animation/css/CSSAnimations.cpp View 1 2 3 4 5 6 7 3 chunks +0 lines, -27 lines 0 comments Download
M sky/engine/core/core.gni View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -5 lines 0 comments Download
M sky/engine/core/css/CSSComputedStyleDeclaration.cpp View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/dom/Document.h View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 1 2 3 4 5 6 7 2 chunks +1 line, -5 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 1 2 3 4 5 6 7 2 chunks +3 lines, -0 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderInline.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 1 2 2 chunks +0 lines, -18 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareNonInheritedData.h View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareNonInheritedData.cpp View 1 2 3 chunks +0 lines, -15 lines 0 comments Download
A sky/examples/animation/basic.sky View 1 2 3 4 5 6 7 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
rafaelw
6 years ago (2014-12-01 21:34:15 UTC) #2
ojan
esprehn: What do you think is the best way to rip out the compositor animations ...
6 years ago (2014-12-01 21:38:39 UTC) #4
ojan
lgtm given that this is dead code.
6 years ago (2014-12-01 21:53:11 UTC) #5
esprehn
You might want to try forcing all animations to the main thread by returning true/false ...
6 years ago (2014-12-02 07:02:02 UTC) #6
rafaelw
6 years ago (2014-12-02 22:04:11 UTC) #7
ojan
lgtm
6 years ago (2014-12-02 22:21:29 UTC) #8
rafaelw
6 years ago (2014-12-02 22:38:12 UTC) #9
Message was sent while issue was closed.
Committed patchset #9 (id:150001) manually as
8c0e929f2e547092bdb8040bcc68611dfc05fcae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698