Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1995)

Unified Diff: sky/engine/core/animation/PendingAnimations.h

Issue 772673002: Fix Animations, Remove Compostior Animations. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: CompositorPendingAnimations -> PendingAnimations Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/animation/DocumentAnimations.cpp ('k') | sky/engine/core/animation/PendingAnimations.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/animation/PendingAnimations.h
diff --git a/sky/engine/core/animation/CompositorPendingAnimations.h b/sky/engine/core/animation/PendingAnimations.h
similarity index 77%
rename from sky/engine/core/animation/CompositorPendingAnimations.h
rename to sky/engine/core/animation/PendingAnimations.h
index a350da1848fd7d2f0262771fb3ecde27f95e72cb..101fb8338e9e2b35eba50097605e7c454315742b 100644
--- a/sky/engine/core/animation/CompositorPendingAnimations.h
+++ b/sky/engine/core/animation/PendingAnimations.h
@@ -28,8 +28,8 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef SKY_ENGINE_CORE_ANIMATION_COMPOSITORPENDINGANIMATIONS_H_
-#define SKY_ENGINE_CORE_ANIMATION_COMPOSITORPENDINGANIMATIONS_H_
+#ifndef SKY_ENGINE_CORE_ANIMATION_PENDINGANIMATIONS_H_
+#define SKY_ENGINE_CORE_ANIMATION_PENDINGANIMATIONS_H_
#include "sky/engine/core/animation/AnimationPlayer.h"
#include "sky/engine/platform/Timer.h"
@@ -43,28 +43,26 @@ namespace blink {
// For CSS Animations, used to synchronize the start of main-thread animations
// with compositor animations when both classes of CSS Animations are triggered
// by the same recalc
-class CompositorPendingAnimations final {
+class PendingAnimations final {
DISALLOW_ALLOCATION();
public:
- CompositorPendingAnimations()
- : m_timer(this, &CompositorPendingAnimations::timerFired)
+ PendingAnimations()
+ : m_timer(this, &PendingAnimations::timerFired)
{ }
void add(AnimationPlayer*);
// Returns whether we are waiting for an animation to start and should
// service again on the next frame.
- bool update(bool startOnCompositor = true);
- void notifyCompositorAnimationStarted(double monotonicAnimationStartTime);
+ bool update();
private:
- void timerFired(Timer<CompositorPendingAnimations>*) { update(false); }
+ void timerFired(Timer<PendingAnimations>*) { update(); }
Vector<RefPtr<AnimationPlayer> > m_pending;
- Vector<RefPtr<AnimationPlayer> > m_waitingForCompositorAnimationStart;
- Timer<CompositorPendingAnimations> m_timer;
+ Timer<PendingAnimations> m_timer;
};
} // namespace blink
-#endif // SKY_ENGINE_CORE_ANIMATION_COMPOSITORPENDINGANIMATIONS_H_
+#endif // SKY_ENGINE_CORE_ANIMATION_PENDINGANIMATIONS_H_
« no previous file with comments | « sky/engine/core/animation/DocumentAnimations.cpp ('k') | sky/engine/core/animation/PendingAnimations.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698