Fix Animations, Remove Compostior Animations.

sky/engine/core/dom/Element.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Peter Kelly (pmk@post.com)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
  *           (C) 2007 Eric Seidel (eric@webkit.org)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 824 matching lines @@
         ElementRareData* data = elementRareData();
 
         // attach() will perform the below steps for us when inside recalcStyle.
         if (!document().inStyleRecalc()) {
             data->clearComputedStyle();
         }
 
         if (ActiveAnimations* activeAnimations = data->activeAnimations()) {
             if (context.performingReattach) {
                 // FIXME: restart compositor animations rather than pull back to the main thread
-                activeAnimations->cancelAnimationOnCompositor();
+                // FIXME(rafaelw): What should we do here?
+                // activeAnimations->cancelAnimationOnCompositor();

[esprehn, 2014/12/02 07:02:02]

I don't think we need to do anything, the animation is already on the main
thread in sky.

             } else {
                 activeAnimations->cssAnimations().cancel();
                 activeAnimations->setAnimationStyleChange(false);
             }
         }
 
         if (ElementShadow* shadow = data->shadow())
             shadow->detach(context);
     }
     ContainerNode::detach(context);
 }
 
 PassRefPtr<RenderStyle> Element::styleForRenderer()
 {
     ASSERT(document().inStyleRecalc());
 
     // FIXME: Instead of clearing updates that may have been added from calls to styleForElement
     // outside recalcStyle, we should just never set them if we're not inside recalcStyle.
     if (ActiveAnimations* activeAnimations = this->activeAnimations())
         activeAnimations->cssAnimations().setPendingUpdate(nullptr);
 
     RefPtr<RenderStyle> style = document().ensureStyleResolver().styleForElement(this);
     ASSERT(style);
 
     // styleForElement() might add active animations so we need to get it again.
     if (ActiveAnimations* activeAnimations = this->activeAnimations()) {
         activeAnimations->cssAnimations().maybeApplyPendingUpdate(this);
-        activeAnimations->updateAnimationFlags(*style);
     }
 
     if (style->hasTransform()) {
         if (const StylePropertySet* inlineStyle = this->inlineStyle())
             style->setHasInlineTransform(inlineStyle->hasProperty(CSSPropertyTransform) || inlineStyle->hasProperty(CSSPropertyWebkitTransform));
     }
 
     document().didRecalculateStyleForElement();
     return style.release();
 }
@@ skipping 897 matching lines @@
         return false;
     // Turn off style sharing for elements that can gain layers for reasons outside of the style system.
     // See comments in RenderObject::setStyle().
     // FIXME: Why does gaining a layer from outside the style system require disabling sharing?
     if (isHTMLCanvasElement(*this))
         return false;
     return true;
 }
 
 } // namespace blink