Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 686103005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed)

Created:
6 years, 1 month ago by RAGHURAM
Modified:
6 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings This step is to move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings (Ref: binding-methods changed: static void storeExceptionOnErrorEventWrapper(ErrorEvent*, v8::Handle<v8::Value>, v8::Handle<v8::Object> creationContext, v8::Isolate*) PassRefPtrWillBeRawPtr<XPathNSResolver> toXPathNSResolver(v8::Handle<v8::Value>, v8::Isolate*) static PassRefPtr<SerializedScriptValue> createAndSwallowExceptions(v8::Handle<v8::Value>, v8::Isolate*)) BUG=424446 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M Source/bindings/core/v8/SerializedScriptValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/SerializedScriptValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8Binding.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8Binding.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8ErrorHandler.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8ErrorHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8Initializer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/WorkerScriptController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/custom/V8CustomEventCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/custom/V8DocumentCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/custom/V8MessageEventCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/v8_types.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/interface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
RAGHURAM
Please Review. Thanks & Regards
6 years, 1 month ago (2014-10-30 10:35:47 UTC) #2
haraken
LGTM
6 years, 1 month ago (2014-10-30 10:37:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686103005/1
6 years, 1 month ago (2014-10-30 10:38:49 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 12:09:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184642

Powered by Google App Engine
This is Rietveld 408576698